Skip to content

feat: prepared-open-api-specs-for-oauth#7148

Open
Zaimwa9 wants to merge 3 commits intofeat/oauth-consent-frontendfrom
feat/update-open-api-generator-for-oauth
Open

feat: prepared-open-api-specs-for-oauth#7148
Zaimwa9 wants to merge 3 commits intofeat/oauth-consent-frontendfrom
feat/update-open-api-generator-for-oauth

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented Apr 7, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #6677

Prepares the MCP OpenAPI spec for OAuth integration with Gram:

  • OAuth security scheme: Added oauth2 (authorization code flow) alongside existing in the MCP OpenAPI spec. Gram reads this to know which authentication methods are supported.
  • Dynamic server URL: The servers URL in the MCP OpenAPI spec now reads from FLAGSMITH_API_URL instead of being. Same for the OAuth authorizationUrl and tokenUrl, derived from FLAGSMITH_FRONTEND_URL and FLAGSMITH_API_URL

How did you test this code?

  • Added tests, waiting for E2E

@Zaimwa9 Zaimwa9 requested a review from gagantrivedi April 7, 2026 09:30
@Zaimwa9 Zaimwa9 requested a review from a team as a code owner April 7, 2026 09:30
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Apr 7, 2026 4:17pm
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 7, 2026 4:17pm
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 7, 2026 4:17pm

Request Review

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7148 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7148 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7148 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7148 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7148 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7148 Finished ✅ Results

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat/oauth-consent-frontend@d63423e). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat/oauth-consent-frontend    #7148   +/-   ##
==============================================================
  Coverage                               ?   98.36%           
==============================================================
  Files                                  ?     1348           
  Lines                                  ?    50635           
  Branches                               ?        0           
==============================================================
  Hits                                   ?    49805           
  Misses                                 ?      830           
  Partials                               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  24 seconds
commit  63c2594
info  🔄 Run: #15819 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  23.8 seconds
commit  e4b8cec
info  🔄 Run: #15818 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  47.4 seconds
commit  63c2594
info  🔄 Run: #15819 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  50.6 seconds
commit  e4b8cec
info  🔄 Run: #15818 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  29.4 seconds
commit  e4b8cec
info  🔄 Run: #15818 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  58.4 seconds
commit  e4b8cec
info  🔄 Run: #15818 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  44 seconds
commit  cec3de1
info  🔄 Run: #15833 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  12.5 seconds
commit  cec3de1
info  🔄 Run: #15833 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  18.1 seconds
commit  cec3de1
info  🔄 Run: #15833 (attempt 1)

…agsmith into feat/update-open-api-generator-for-oauth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant