Skip to content

fix(Integrations): Let HubSpot handle company creation and association#7147

Open
Holmus wants to merge 1 commit intomainfrom
fix/hubspot-let-hubspot-handle-companies
Open

fix(Integrations): Let HubSpot handle company creation and association#7147
Holmus wants to merge 1 commit intomainfrom
fix/hubspot-let-hubspot-handle-companies

Conversation

@Holmus
Copy link
Copy Markdown
Contributor

@Holmus Holmus commented Apr 7, 2026

The HubSpot lead tracking integration was creating and updating companies from Flagsmith org data, overwriting enriched company names with user-entered org names. HubSpot already handles company creation and contact association automatically from email domains.

Changes

  • Simplify create_lead to only create the contact - HubSpot handles company creation and association
  • Simplify should_track to just check if the feature is enabled - HubSpot handles domain filtering natively
  • Remove regex import (no longer needed)
  • Remove obsolete tests for company association and domain filtering

Review effort: 1/5

🤖 Generated with Claude Code

The HubSpot lead tracking integration was creating and updating
companies from Flagsmith org data, overwriting enriched company
names with user-entered org names. HubSpot already handles company
creation and contact association automatically from email domains.

Simplify create_lead to only create the contact. Remove domain
filtering from should_track since HubSpot handles that natively.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@Holmus Holmus requested a review from a team as a code owner April 7, 2026 07:59
@Holmus Holmus requested review from khvn26 and removed request for a team April 7, 2026 07:59
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Apr 7, 2026 7:59am
flagsmith-frontend-preview Ignored Ignored Apr 7, 2026 7:59am
flagsmith-frontend-staging Ignored Ignored Apr 7, 2026 7:59am

Request Review

@github-actions github-actions bot added api Issue related to the REST API fix labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7147 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7147 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-7147 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7147 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7147 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7147 Finished ✅ Results

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.32%. Comparing base (c5af2d5) to head (ba4aa50).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7147      +/-   ##
==========================================
- Coverage   98.34%   98.32%   -0.03%     
==========================================
  Files        1336     1336              
  Lines       50161    50133      -28     
==========================================
- Hits        49331    49291      -40     
- Misses        830      842      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  37.6 seconds
commit  ba4aa50
info  🔄 Run: #15815 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  28.6 seconds
commit  ba4aa50
info  🔄 Run: #15815 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  1 minute, 3 seconds
commit  ba4aa50
info  🔄 Run: #15815 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  56.2 seconds
commit  ba4aa50
info  🔄 Run: #15815 (attempt 1)

@matthewelwell matthewelwell requested a review from Zaimwa9 April 7, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant