Skip to content

feat: support Azure managed identities#7131

Draft
matthewelwell wants to merge 1 commit intomainfrom
feat/support-azure-managed-identities
Draft

feat: support Azure managed identities#7131
matthewelwell wants to merge 1 commit intomainfrom
feat/support-azure-managed-identities

Conversation

@matthewelwell
Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to

Please describe.

How did you test this code?

Please describe.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Apr 3, 2026 4:37pm
flagsmith-frontend-preview Ignored Ignored Apr 3, 2026 4:37pm
flagsmith-frontend-staging Ignored Ignored Apr 3, 2026 4:37pm

Request Review

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.34%. Comparing base (7f8e104) to head (14c921c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7131   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files        1336     1336           
  Lines       50128    50128           
=======================================
  Hits        49298    49298           
  Misses        830      830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +180 to +182
USE_AZURE_MANAGED_IDENTITY_FOR_DB_AUTH = env(
"USE_AZURE_MANAGED_IDENTITY_FOR_DB_AUTH", default=False
)
Copy link
Copy Markdown
Member

@khvn26 khvn26 Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's namespace it

Suggested change
USE_AZURE_MANAGED_IDENTITY_FOR_DB_AUTH = env(
"USE_AZURE_MANAGED_IDENTITY_FOR_DB_AUTH", default=False
)
USE_AZURE_MANAGED_IDENTITY_FOR_DB_AUTH = env(
"DJANGO_DB_USE_AZURE_MANAGED_IDENTITY", default=False
)

Plus, would be cool to signal this via the dsn somehow, e.g.

azuread+postgresql://user@server/database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants