Skip to content

Conversation

@Holmus
Copy link
Contributor

@Holmus Holmus commented Dec 29, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Restructured RBAC docs with clearer explanations of permission levels (organisation/project/environment) and role types
  • Added practical examples for common permission setups (developers with production restrictions, QA read-only access, etc.)
  • Updated change requests docs with a permissions table for create/approve/publish actions
  • Added permissions section to data model docs explaining how permissions align with the data hierarchy

How did you test this code?

Ran docs locally, verified SVGs look good, that links work, that the text makes sense and that the general order concepts are presented in makes sense.

@Holmus Holmus requested a review from a team as a code owner December 29, 2025 11:41
@Holmus Holmus requested review from matthewelwell and removed request for a team December 29, 2025 11:41
@vercel
Copy link

vercel bot commented Dec 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 5, 2026 10:58am
2 Skipped Deployments
Project Deployment Review Updated (UTC)
flagsmith-frontend-preview Ignored Ignored Preview Jan 5, 2026 10:58am
flagsmith-frontend-staging Ignored Ignored Preview Jan 5, 2026 10:58am

@github-actions github-actions bot added the docs Documentation updates label Dec 29, 2025
@khvn26
Copy link
Member

khvn26 commented Dec 29, 2025

Kindly check the linting failure:

  [cause]: Error: Docusaurus found broken links!
  
  Please check the pages of your site in the list below, and make sure you don't reference any path that does not exist.
  Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.
  
  Exhaustive list of all broken links found:
  - Broken link on source page path = /administration-and-security/access-control/rbac:
     -> linking to /project-management/tags

matthewelwell
matthewelwell previously approved these changes Dec 31, 2025
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the whole, this seems like a great improvement. I've added a few minor suggestions and one question, but nothing that is strictly necessary I don't think.

@Holmus Holmus merged commit 16beab7 into main Jan 5, 2026
12 checks passed
@Holmus Holmus deleted the docs/clarify-rbac branch January 5, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants