fix: Support flat attributes in the evaluation context#26
Merged
khvn26 merged 4 commits intoFlagsmith:mainfrom Feb 26, 2026
Merged
fix: Support flat attributes in the evaluation context#26khvn26 merged 4 commits intoFlagsmith:mainfrom
khvn26 merged 4 commits intoFlagsmith:mainfrom
Conversation
Signed-off-by: Danju Visvanathan <danju.visvanathan@gmail.com>
danjuv
changed the title
Signed-off-by: Danju Visvanathan <danju.visvanathan@gmail.com>
Signed-off-by: Danju Visvanathan <danju.visvanathan@gmail.com>
khvn26
requested changes
Feb 25, 2026
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
Thanks again for your contribution. The code looks good to me!
I approve of the solution used, but I'd like it to be documented somewhere — let's start with adding a small section to the README of this repo.
Contributor
Author
|
@khvn26 added a small section, let me know if you think it gets the point across |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Notes
Alternatively, can deprecate "traits" as an evaluation context attribute, but that's a breaking change and will defer to repository maintainers on that.
closes #24