fix: Reasons for environment default flags

[bakirFS]

Closes #341

When a flag falls back to its environment default, the engine always returned the DEFAULT reason.

Now:

• STATIC if no segment overrides the feature
• DEFAULT if the feature has segment overrides, but none matched

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 56eb3671-c541-4da4-a434-d0e55b7b124f

📥 Commits

Reviewing files that changed from the base of the PR and between edc1d08 and 0ae1af5.

📒 Files selected for processing (2)

• .gitmodules
• tests/engine_tests/engine-test-data

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 2879153d-8478-4b74-8c50-6ce4c0693c8f

📥 Commits

Reviewing files that changed from the base of the PR and between fdf0448 and edc1d08.

📒 Files selected for processing (3)

• .gitmodules
• tests/engine_tests/engine-test-data
• tests/unit/test_engine.py

💤 Files with no reviewable changes (1)

• tests/unit/test_engine.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Feature evaluation assigns DEFAULT when segment overrides target a feature, and STATIC when they do not. Dependency resolution applies the same distinction when no segment override matches. Unit tests update expected reasons. The engine test-data submodule branch and commit reference also change.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to edc1d

Environment-default flags now report STATIC when no segment overrides target the feature, and DEFAULT when overrides exist but none match. No merge-blocking risk was found in the supplied changes.

Architecture Summary

Architecture risk: 🔵 Low · up to fdf04

The change affects 2 systems.

Changed systems: tests, flag_engine

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — tests (service) was modified; 2 changed files map to changed impact.
• observed — flag_engine (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in flag_engine/segments/evaluator.py: evaluate_features now collects feature names targeted by segment overrides before evaluating features.
• observed — Modified behavior in flag_engine/segments/evaluator.py: Fallback reasons now come from get_fallback_reason rather than always being DEFAULT; features targeted by any segment get DEFAULT, while untargeted features get STATIC. The new helper gathers override feature names across all segments and applies that rule.
• observed — Modified behavior in flag_engine/segments/evaluator.py: Adds get_targeted_feature_names to collect override names from segment contexts and get_fallback_reason to return DEFAULT for targeted features and STATIC otherwise.
• observed — Modified behavior in flag_engine/segments/evaluator.py: When dependency resolution finds no matching segment override, the fallback reason now uses the feature’s segment-key index: DEFAULT if it appears in that index, otherwise STATIC, replacing the unconditional DEFAULT.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 51341f3c-fda6-4137-8c93-7e7e4d96bded

📥 Commits

Reviewing files that changed from the base of the PR and between 31dc381 and 1549b48.

📒 Files selected for processing (2)

• flag_engine/segments/evaluator.py
• tests/unit/test_engine.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[github-actions]

File	Coverage		Missing
All files	100%	✅

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against 0ae1af5

[codspeed]

Merging this PR will not alter performance

✅ 1 untouched benchmark

---

_{Comparing fix/reason-environment-default (0ae1af5) with main (31dc381)}

[khvn26]

Just a couple changes needed.

[khvn26]

LGTM 👍