Skip to content

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 27, 2025

This PR brings a fix to #275 along with a number of improvements:

  • Segment and feature evaluations abstracted out akin to @Zaimwa9's Node JS engine implementation.
  • The generated identity key is written to the evaluation context itself by a newly introduced enrich_context evaluation phase.

@khvn26 khvn26 requested a review from a team as a code owner October 27, 2025 14:47
@khvn26 khvn26 requested review from Zaimwa9 and removed request for a team October 27, 2025 14:47
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

File Coverage Missing
All files 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against d8c68aa

@github-actions
Copy link

File Coverage Missing
All files 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against 327631b

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 27, 2025

CodSpeed Performance Report

Merging #276 will not alter performance

Comparing fix/implicit-key-not-supported-for-percentage-split (d8c68aa) with main (38c6673)

Summary

✅ 1 untouched

Zaimwa9
Zaimwa9 previously approved these changes Oct 28, 2025
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@khvn26 khvn26 force-pushed the fix/implicit-key-not-supported-for-percentage-split branch from bdc9a1a to d8c68aa Compare October 28, 2025 11:48
@khvn26 khvn26 merged commit 4d0fa9a into main Oct 28, 2025
8 checks passed
@khvn26 khvn26 deleted the fix/implicit-key-not-supported-for-percentage-split branch October 28, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants