ci: add msvc-x86 (32-bit) build leg#120
Merged
Merged
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This was referenced Jun 26, 2026
CI only built x64, so x86-only breakage slipped past (e.g. the ODBC driver C2733/C4100, and uint64->size_t narrowing C4244/C2220 under /WX that only fires on 32-bit). Many deployments still ship x86, so add a windows-2022 / msvc-x86 leg to the matrix to catch it going forward. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Admnwk
force-pushed
the
ci/add-x86-msvc-leg
branch
from
36d653d to
fdc44cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI only builds x64, so x86-only breakage slips through unnoticed:
uint64_t→size_t/unsigned) →C4244/C2220under/WX(issue error compiling with msvc 2026 x86 in windows #3)SQLColAttributeSQLLEN*on x64 vsSQLPOINTERon x86) →C2733(see companion PR fix: unbreak build (AE_PARSE_ERROR) + ODBC driver x86 (C4100/C2733) #119)/WXC4100unreferenced paramsMany deployments still ship 32-bit, and FiveTech publishes an x86 release. This adds a
windows-2022 / msvc-x86leg to the CI matrix so 32-bit breakage is caught on every PR, not only at release-tag time.Note
Depends on PR #119 (fixes the current x86 breakage). Merge #119 first, or this leg will be red until it lands — that's the point: it would have caught #119's issues automatically.
🤖 Generated with Claude Code