fix(profiles): include sync with archive workflows - #1663
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughCustom profiles that select ChangesArchive Sync Dependency
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This localized change ensures archive workflows include their required sync dependency while preserving existing profile selections; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying openspec-docs with
|
| Latest commit: |
8727b30
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e0e8859e.openspec-docs.pages.dev |
| Branch Preview URL: | https://codex-fix-archive-sync-depen.openspec-docs.pages.dev |
Risk: low. Adds a missing dependency to profile resolution. Existing profiles that already include sync are untouched.
What was wrong
A custom profile could select the archive or bulk-archive workflow without selecting sync. The generated archive workflow then called a sync workflow that was never installed, so archive either stopped or improvised the main-spec update. Legacy Codex prompt migration could produce the same broken combination.
What changes
Selecting either archive workflow now pulls in sync automatically, in both profile resolution and Codex migration.
Why it's safe
Custom profiles stay user-owned: accepting an unchanged selection does not convert it to a core preset or rewrite the user's raw workflow list. Sync is never duplicated or reordered when already present.
Proof
Reproduced on
mainwith a propose/explore/apply/archive profile: 4 skills generated, archive referencing an absent workflow. Now 5 are generated, including sync. Update regressions start from pre-fix archive-only installs and prove repair for both skills and commands. CI green on all three platforms.Fixes #1650
Summary by CodeRabbit
Bug Fixes
Improvements