Skip to content

fix(update): only suggest IDE restarts when needed - #1656

Merged
clay-good merged 3 commits into
mainfrom
codex/fix-update-restart-hint
Aug 19, 2026
Merged

fix(update): only suggest IDE restarts when needed#1656
clay-good merged 3 commits into
mainfrom
codex/fix-update-restart-hint

Conversation

@clay-good

@clay-good clay-good commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Risk: none. Output only — one line of text is now conditional. No files, config or commands change.

What was wrong

openspec update ended with "Restart your IDE for changes to take effect." for every tool, including pure CLI tools like Claude Code, Codex and Gemini CLI, which have no IDE to restart. openspec init already got this right.

What changes

The hint prints only when a tool that actually lives in an IDE received commands or skills. It reuses the same requiresIdeRestart metadata init already uses.

Why it's safe

Cursor and other IDE tools still get the hint. The only difference is that CLI-only updates stop printing advice that can't apply.

Proof

Regression coverage for CLI-only, IDE-only, mixed and partially-failed updates. Packaged CLI check: a forced Claude Code update omits the hint, a forced Cursor update keeps it. 3,971 tests pass; CI green on all three platforms.

Closes #1608

@clay-good
clay-good requested a review from a team as a code owner August 14, 2026 19:26
@clay-good
clay-good requested review from TabishB and removed request for a team August 14, 2026 19:26
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1fdac588-1743-4933-8387-d6e74db84ba3

📥 Commits

Reviewing files that changed from the base of the PR and between 3437de8 and 2c64d2b.

📒 Files selected for processing (1)
  • test/core/update.test.ts

📝 Walkthrough

Walkthrough

openspec update now tracks affected tools and displays IDE restart guidance only for tools that require it. Tests cover successful and failed IDE updates, CLI-only updates, unaffected tools, and legacy upgrades. A patch changeset documents the behavior.

Changes

Update restart guidance

Layer / File(s) Summary
Conditional restart logic
src/core/update.ts
The update process records updated tool IDs and shows the restart notice only when an affected tool requires an IDE restart and generates skills or commands.
Restart guidance validation
test/core/update.test.ts, .changeset/quiet-cli-update.md
Tests cover Cursor and Claude updates, failure paths, unaffected IDE tools, and legacy upgrades. The changeset documents the narrowed restart behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 2c64d

The update summary now shows IDE restart guidance only when applicable; this is a localized output change with no actionable merge-blocking risk remaining after normal checks.

Possibly related PRs

Suggested reviewers: tabishb, alfred-openspec

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The implementation gates restart guidance by tool requirements and update success, suppressing hints for CLI tools while retaining them for IDE tools [#1608].
Out of Scope Changes check ✅ Passed The changeset, implementation, and regression tests directly support the linked issue and contain no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: limiting IDE restart suggestions to cases where they are needed.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-update-restart-hint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying openspec-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 45e8c70
Status: ✅  Deploy successful!
Preview URL: https://1d0cd39a.openspec-docs.pages.dev
Branch Preview URL: https://codex-fix-update-restart-hin.openspec-docs.pages.dev

View logs

@clay-good
clay-good added this pull request to the merge queue Aug 19, 2026
Merged via the queue into main with commit a72a74d Aug 19, 2026
18 checks passed
@clay-good
clay-good deleted the codex/fix-update-restart-hint branch August 19, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openspec update still shows 'Restart your IDE' hint unconditionally (CLI tools included)

2 participants