fix(update): only suggest IDE restarts when needed - #1656
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesUpdate restart guidance
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The update summary now shows IDE restart guidance only when applicable; this is a localized output change with no actionable merge-blocking risk remaining after normal checks. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying openspec-docs with
|
| Latest commit: |
45e8c70
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1d0cd39a.openspec-docs.pages.dev |
| Branch Preview URL: | https://codex-fix-update-restart-hin.openspec-docs.pages.dev |
Risk: none. Output only — one line of text is now conditional. No files, config or commands change.
What was wrong
openspec updateended with "Restart your IDE for changes to take effect." for every tool, including pure CLI tools like Claude Code, Codex and Gemini CLI, which have no IDE to restart.openspec initalready got this right.What changes
The hint prints only when a tool that actually lives in an IDE received commands or skills. It reuses the same
requiresIdeRestartmetadatainitalready uses.Why it's safe
Cursor and other IDE tools still get the hint. The only difference is that CLI-only updates stop printing advice that can't apply.
Proof
Regression coverage for CLI-only, IDE-only, mixed and partially-failed updates. Packaged CLI check: a forced Claude Code update omits the hint, a forced Cursor update keeps it. 3,971 tests pass; CI green on all three platforms.
Closes #1608