Conversation
Step-40 left it without a caller; its docstring says step-42 deletes it. Also drops stale mentions from three test files whose commentary referenced the class. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
fromAstOrText and fromText have no caller: every parsed tree carries the namespace and use nodes, so callers read fromAst directly. The test file that covered only the deleted paths goes with them; fromAst has coverage through SymbolResolverTest CoversClass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Steps 37, 40, and 41 moved every regex home elsewhere. The remaining methods (findEnclosingClass, findEnclosingClassFromContent, findNamespace, matchParameterType, resolveEnclosingClassName) have no caller once the tree always carries the enclosing class and namespace. Drops the AstTextAgreementTest sections that pinned agreement with the deleted paths, and the stale comment names in SymbolResolverTest and CompletionParityTest. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Removes the disallowedMethodCalls entry for resolveEnclosingClassName and the regex allowlist path for src/Resolution/TextFallbackHelper.php: both name a class that no longer exists. Drops the one-route ledger text-helper row with the class it watched. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
CLAUDE.md no longer names TextFallbackHelper: incomplete code is handled inside SymbolResolver through the SyntaxSource composite, which falls through to CursorTextSyntaxSource. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
============================================
+ Coverage 99.24% 99.45% +0.21%
+ Complexity 1915 1889 -26
============================================
Files 140 138 -2
Lines 5033 4977 -56
============================================
- Hits 4995 4950 -45
+ Misses 38 27 -11 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 42 of
docs/architecture/build-manifest.md.Done
src/Resolution/TextFallbackHelper.phpandEnclosingClassResolver.phpare gone —git log,composer test.NameContextFactoryhas one public constructor method (fromAst) —git diff,composer test.SymbolResolverconstructor builds no text helper —composer test.OneRoutePerFactTest.CLAUDE.mdno longer says incomplete code is handled viaTextFallbackHelper—git diff CLAUDE.md.disallowedMethodCallsentry forTextFallbackHelper::resolveEnclosingClassNameand the regex allowlist path for the helper are gone —composer phpstan.🤖 Generated with Claude Code