feat(readiness-probe-improvements): AIPLAT-916#185
Open
subpath wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: AIPLAT-916
Infra PR companion should be merged first: https://github.com/mozilla/dataservices-infra/pull/2090
What's New
/health/readiness now answers
"can this pod serve a request right now?"via the HTTP status code, instead of always returning 200.Kubernetes routes on the status code, so a pod with a down Postgres pool or a stale app_attest schema now drains from rotation instead of serving 500s.
Three checks run concurrently (asyncio.gather), each bounded by READINESS_CHECK_TIMEOUT_S (2s). All pass -> 200; any fail -> 503 with the failing check named in the body:
Liveness stays a constant {"status": "alive"}, so a dependency blip drains the pod without ever restarting it, no crash-loop path from this change.
QA:
all new unit tests ✅