Repository navigation
Conversation
Use qualified member names in sizeof expressions. The operands remain unevaluated and the page-capacity calculations retain the same array sizes.
dyemanov
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the null-pointer member expressions in maxPagesPerSCN and gensPerPage with sizeof(scns_page::scn_pages) and sizeof(generator_page::gpg_values).
This is a readability cleanup, not a runtime null-dereference fix: sizeof does not evaluate these operands. The full array types and resulting page-capacity arithmetic remain unchanged.
Validation on Linux x86-64 with GCC 16.2 / C++20:
A full patched server build has not been completed locally.