Repository navigation
Conversation
Cast L1 and R1 to ULONG before left shift operations to avoid undefined behavior when these signed values are negative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert L1 and R1 to ULONG with static_cast before the final left shifts in des_cipher. This preserves the output bits while avoiding shifts of negative signed values in pre-C++20 builds.
The negative-shift UBSan diagnostic is reproducible in C++17. Master now uses C++20, so this PR does not claim the same operation is undefined under master's current language mode; the change also provides a small backportable fix for the Firebird 5 line.
Validation on Linux x86-64:
left shift of negative value -1608722304on the unpatched code under Clang 21 / C++17 / UBSan.A complete patched server build has not been completed locally; the algorithm harness does not test Firebird's locking or initialization lifecycle.