ci: stop publishing the legacy FIPS images (#48) - #49
Merged
Merged
Conversation
Every known consumer now references filigran/alpine-python-fips and filigran/alpine-python-nodejs-fips, so the migration window kept open by the legacy workflow closes. The workflow, legacy/ and the Renovate managers for the OpenSSL and CPython pins that only those Dockerfiles used are removed, and the README notes that the previous images are no longer published. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Xavier Fournet (xfournet)
added
filigran team
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The legacy build path and its references are consistently removed, matching issue #48 and the PR description.
Review effort: Balanced
Findings: None
What changed in this PR
Retires legacy FIPS image publishing after consumers migrated to Alpine-prefixed images.
Changes:
- Removes legacy Dockerfiles, OpenSSL configuration, and publishing workflow.
- Removes obsolete Renovate rules and workflow path exclusions.
- Documents legacy image retirement and replacements.
| File | Description |
|---|---|
.github/workflows/docker-build-push-legacy.yml |
Removes legacy publishing workflow. |
.github/workflows/docker-build-push.yml |
Runs for all repository changes. |
legacy/Dockerfile_python |
Removes legacy Python image. |
legacy/Dockerfile_python_nodejs |
Removes legacy Python/Node.js image. |
legacy/openssl.cnf |
Removes legacy OpenSSL configuration. |
renovate.json5 |
Removes legacy dependency managers and rule. |
README.md |
Documents retired images and replacements. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
.github/workflows/docker-build-push-legacy.ymlandlegacy/, which builtfiligran/python-fipsandfiligran/python-nodejs-fips.paths-ignore: legacy/**filters from the main workflow.python/cpythonversion rule that constrained them — nothing else declares those dependencies.Related issues
How to test this PR
The main workflow runs on this pull request and builds both images without publishing them. Nothing in the repository references
legacy/any more:grep -rn legacy . --exclude-dir=.gitChecklist
type(scope?): description (#issue)Further comments
The nine
Dockerfile_fipsin OpenCTI-Platform that used the previous images —opencti-platform,opencti-workerand seven internal connectors — already reference the new names on their default branches. Once this is merged,filigran/python-fipsandfiligran/python-nodejs-fipsstop receiving updates.🤖 Generated with Claude Code