Skip to content

harden: the api in Api.js #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

harden: the api in Api.js #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/Api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,20 @@ const fetchWithRetry = async (url, options, retries = 0) => {
}
}

const isDisallowedExternalUrl = (url) => {
try {
const { protocol, hostname } = new URL(url)

if (!/^https?:$/.test(protocol)) {
return true
}

return /^(?:localhost|0\.|10\.|127\.|169\.254\.|172\.(?:1[6-9]|2\d|3[01])\.|192\.168\.|\[?::1\]?|\[?fd[0-9a-f]{2}:)/i.test(hostname)
} catch {
return true
}
}

class Api {
static _sendVerbatim = async (path, verb, optionsRaw) => {
const { getAgentForUrl, ...options } = optionsRaw || {}
Expand All @@ -52,6 +66,10 @@ class Api {
throw new errors.ConfigurationError('Base URL has not been set - use Files.setBaseUrl() to set it')
}

if (isExternal && isDisallowedExternalUrl(path)) {
throw new errors.ConfigurationError('Refusing to send request to a disallowed URL')
}

const url = isExternal
? path
: `${baseUrl}${Files.getEndpointPrefix()}${path}`
Expand Down