Skip to content

feat!: change params to options object and remove withIpni#601

Merged
hugomrdias merged 11 commits intomasterfrom
hugomrdias/obj-params
Feb 11, 2026
Merged

feat!: change params to options object and remove withIpni#601
hugomrdias merged 11 commits intomasterfrom
hugomrdias/obj-params

Conversation

@hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Feb 10, 2026

  • changes most services to options object
  • removes deprecated methods
  • migration guide

@hugomrdias hugomrdias requested a review from rvagg as a code owner February 10, 2026 15:19
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Feb 10, 2026
@hugomrdias hugomrdias self-assigned this Feb 10, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 10, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
synapse-dev 396af06 Commit Preview URL

Branch Preview URL
Feb 11 2026, 04:57 PM

@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FOC Feb 10, 2026
@rjan90 rjan90 added this to the M4.0: mainnet staged milestone Feb 10, 2026
@hugomrdias hugomrdias force-pushed the hugomrdias/obj-params branch from e124516 to 30ae9b8 Compare February 10, 2026 17:08
Base automatically changed from hugomrdias/pdp-server-out to master February 10, 2026 18:27
@hugomrdias hugomrdias force-pushed the hugomrdias/obj-params branch from 831d2a8 to cdd7473 Compare February 10, 2026 18:28
@hugomrdias hugomrdias linked an issue Feb 10, 2026 that may be closed by this pull request
3 tasks
@hugomrdias hugomrdias removed a link to an issue Feb 10, 2026
3 tasks
@hugomrdias hugomrdias linked an issue Feb 10, 2026 that may be closed by this pull request
This was referenced Feb 10, 2026
})

if (client.account.type === 'json-rpc' && client.transport.type !== 'custom') {
throw new Error('Transport must be a custom transport. See https://viem.sh/docs/clients/transports/custom.')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to dig into what this is all about, the error message is not very helpful here and I'm willing to bet even viem users wouldn't grok the subtlties of this.

We could be verbose and reuse this across PaymentsService, WarmStorageService and SPRegistryService.

Account delegates signing to an external provider, but the current transport doesn't connect to it. Pass the signing provider as transport: custom(provider). See https://viem.sh/docs/clients/transports/custom

?

@hugomrdias hugomrdias changed the title feat: change params to options object feat!: change params to options object and remove withIpni Feb 11, 2026
@hugomrdias hugomrdias merged commit 0d529e2 into master Feb 11, 2026
11 checks passed
@hugomrdias hugomrdias deleted the hugomrdias/obj-params branch February 11, 2026 16:57
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to 🎉 Done in FOC Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Migration Guide / Docs - Mainnet Ready Synapse Release

3 participants