feat!: change params to options object and remove withIpni#601
Merged
hugomrdias merged 11 commits intomasterfrom Feb 11, 2026
Merged
feat!: change params to options object and remove withIpni#601hugomrdias merged 11 commits intomasterfrom
hugomrdias merged 11 commits intomasterfrom
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | 396af06 | Commit Preview URL Branch Preview URL |
Feb 11 2026, 04:57 PM |
e124516 to
30ae9b8
Compare
…permit deadlines, and standardize client address parameter
…ageInfo and change download method to object params
831d2a8 to
cdd7473
Compare
Open
3 tasks
rvagg
reviewed
Feb 11, 2026
docs/src/content/docs/developer-guides/payments/payment-operations.mdx
Outdated
Show resolved
Hide resolved
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
| }) | ||
|
|
||
| if (client.account.type === 'json-rpc' && client.transport.type !== 'custom') { | ||
| throw new Error('Transport must be a custom transport. See https://viem.sh/docs/clients/transports/custom.') |
Collaborator
There was a problem hiding this comment.
I had to dig into what this is all about, the error message is not very helpful here and I'm willing to bet even viem users wouldn't grok the subtlties of this.
We could be verbose and reuse this across PaymentsService, WarmStorageService and SPRegistryService.
Account delegates signing to an external provider, but the current transport doesn't connect to it. Pass the signing provider as transport: custom(provider). See https://viem.sh/docs/clients/transports/custom
?
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
rvagg
reviewed
Feb 11, 2026
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.