[WIP] createContexts

[wjmelements]

Reviewers @rvagg @hugomrdias

Context

Toward #312

Changes

• mockServiceProviderRegistry
• WIP createContexts

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	synapse-dev	6393997	Commit Preview URL Branch Preview URL	Oct 22 2025, 03:57 AM

[rvagg]

Now that we're exposting this, we're essentially exposing ProviderSelectionResult as a public type that someone might use. So we should look at this flow a little more critically.

• We use -1 to signal that a new dataSet needs to be made, but we could also just omit it for that case I think.
• The type has a bizzaro isNewDataSet that's not used anywhere. Let's remove that.
• isExisting is only used for the callback, but also is now overloading our use of -1 in dataSetId, so we don't really need it now either
• The type really is a combination of Provider+DataSet (which is what a Context is supposed to be structured around), so how about we rename it.

Here's an interesting option, make it an "intent" for how we want the context to be:

  interface StorageContextIntent {
    provider: ProviderInfo
    dataSetIntent:
      | { action: 'create', metadata: Record<string, string> }
      | { action: 'reuse', id: number, metadata: Record<string, string> }
  }

Simple variation that's not to different to now:

  interface ProviderDataSetSelection {
    provider: ProviderInfo
    dataSetId?: number  // undefined = needs creation
    dataSetMetadata: Record<string, string>
  }

But I think I like the explicit descriptiveness of an intent.

[wjmelements]

I was planning to make this method private

[wjmelements]

that's an evil rebase

[rvagg]

that's an evil rebase
then don't give me merge commits to deal with, they're not making it in to master and we're not squash merging a huge amount of disparate functionality

[wjmelements]

Planning to close this and open a new PR.

[wjmelements]

Closing in favor of #368