feat: add support for postgres schema selection by gkorland · Pull Request #475 · FalkorDB/QueryWeaver

gkorland · 2026-03-09T08:32:50Z

Summary

Adds support for selecting a PostgreSQL schema instead of always using public. Based on PR #373 by @sirudog, rebased onto current staging with bug fixes.

What changed

Backend: New _parse_schema_from_url() extracts schema from the connection URL's options parameter (search_path), following PostgreSQL's native libpq format
SQL queries: All information_schema queries now accept a parameterized schema argument (default: public) — no SQL injection risk
UI: Schema input field in DatabaseModal, shown only for PostgreSQL connections
Tests: 14 new unit tests for URL schema parsing (edge cases, encoding, $user handling)
Docs: Custom schema configuration guide with examples and troubleshooting

Fixes over original PR #373

pg_namespace JOIN order in extract_columns_info — the original used LEFT JOIN pg_class then LEFT JOIN pg_namespace, which doesn't filter duplicate pg_class rows when same-named tables exist across schemas. Fixed by joining pg_namespace first and folding the namespace filter into the pg_class join condition
Regex pattern — changed [=\s]+ to \s*=\s* to require = as separator, preventing mis-capture when search_path= is followed by a space and another option
$user handling — replaced two-position check with a loop through all schemas, correctly handling edge cases like \$user,\$user,public
Pylint compliance — fixed line-too-long, added protected-access disable for test class

Backward compatibility

All methods default to public schema, so existing connections without search_path work identically.

Closes #373 (supersedes)

Add support for selecting a PostgreSQL schema instead of always using 'public'. The schema is extracted from the connection URL's options parameter (search_path), following PostgreSQL's native libpq format. Changes: - Add _parse_schema_from_url() to extract schema from connection URL - Thread schema parameter through all extraction methods with 'public' default - Add pg_namespace JOINs for correct cross-schema disambiguation - Add schema input field in DatabaseModal (PostgreSQL only) - Add comprehensive unit tests for URL schema parsing - Update documentation with custom schema configuration guide Based on PR #373 by sirudog with the following fixes: - Fix pg_namespace JOIN order in extract_columns_info to prevent duplicate rows when same-named tables exist across schemas - Fix regex to require '=' separator (prevents mis-capture edge cases) - Improve $user handling to loop through all schemas instead of only checking first two positions - Fix pylint line-too-long in test file Co-authored-by: sirudog <1550561+sirudog@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

overcut-ai · 2026-03-09T08:32:53Z

Completed Working on "Code Review"

✅ Workflow completed successfully.

👉 View complete log

railway-app · 2026-03-09T08:32:57Z

🚅 Deployed to the QueryWeaver-pr-475 environment in queryweaver

Service	Status	Web	Updated (UTC)
QueryWeaver	✅ Success (View Logs)	Web	Mar 9, 2026 at 10:05 am

github-actions · 2026-03-09T08:33:05Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 5 package(s) with unknown licenses.

See the Details below.

License Issues

uv.lock

Package	Version	License	Issue Type
falkordb	1.6.0	Null	Unknown License
litellm	1.82.0	Null	Unknown License
playwright	1.58.0	Null	Unknown License
redis	7.3.0	Null	Unknown License
uvicorn	0.41.0	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
pip/falkordb	1.6.0	Unknown	Unknown
pip/litellm	1.82.0	Unknown	Unknown
pip/playwright	1.58.0	Unknown	Unknown
pip/redis	7.3.0	Unknown	Unknown
pip/uvicorn	0.41.0	Unknown	Unknown

Scanned Files

uv.lock

coderabbitai · 2026-03-09T08:33:07Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fd180f9b-e3b0-4881-a435-4a6c2be44aa6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/select-postgres-schema

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

overcut-ai

Thanks for the schema-selection enhancement—there are 6 MAJOR findings in total (no BLOCKER/CRITICAL/MINOR/SUGGESTION/PRAISE items).

Summary of findings

Importance counts: 6 MAJOR
Affected files: 4 (api/loaders/postgres_loader.py, app/src/components/modals/DatabaseModal.tsx, tests/test_postgres_loader.py, docs/postgres_loader.md)

Key themes observed

Schema parsing robustness gaps in search_path handling (quoted commas and edge-token handling) that can select the wrong schema.
Schema-scoping correctness issues in metadata joins where non-unique constraint names across schemas can lead to incorrect PK/FK attribution.
Coverage and usability gaps: missing regression tests for documented edge cases and a docs snippet using an incorrect class name.

Actionable next steps

Harden search_path parsing/tokenization (or delegate to server-side schema resolution) and safely encode/validate schema input from UI.
Fix constraint joins to include schema-qualified keys (constraint_schema/table_schema) to prevent cross-schema collisions.
Add regression tests for repeated $user and empty-token-only search_path values, then correct the documentation import/example to match implementation.

app/src/components/modals/DatabaseModal.tsx

docs/postgres_loader.md

api/loaders/postgres_loader.py

tests/test_postgres_loader.py

Rename _parse_schema_from_url to parse_schema_from_url since the method is already documented for external use and tested directly. This eliminates W0212 (protected-access) warnings that cause CI pylint to fail with exit code 4. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Add constraint_schema qualifier to key_column_usage JOINs in extract_columns_info to prevent cross-schema constraint name collisions - Sanitize schema input in DatabaseModal to strip non-identifier characters before building the URL options - Add edge case tests: empty tokens, blank quoted tokens, repeated $user entries Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds support for targeting a specific PostgreSQL schema (instead of always public) by parsing search_path from the connection URL’s options parameter, threading the schema through metadata queries, and exposing an optional schema field in the UI for PostgreSQL manual connections.

Changes:

Backend: added PostgresLoader.parse_schema_from_url() and parameterized information_schema queries by schema (default public).
UI: added an optional “Schema” input (PostgreSQL-only) that encodes options=-csearch_path=<schema> into the built connection URL.
Tests/Docs: added unit tests for URL schema parsing and documentation/examples for custom schema configuration.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`api/loaders/postgres_loader.py`	Parses schema from connection URL and uses it to scope table/column/FK extraction queries.
`app/src/components/modals/DatabaseModal.tsx`	Adds PostgreSQL-only schema input and injects `search_path` into connection URL options for manual mode.
`tests/test_postgres_loader.py`	Adds unit tests covering `search_path` parsing edge cases.
`docs/postgres_loader.md`	Documents custom schema configuration via `options=-csearch_path=...` and troubleshooting guidance.
`README.md`	Fixes markdown code block formatting around the streaming Python example.
`.github/wordlist.txt`	Adds `PostgresLoader` to the spellcheck allowlist.

api/loaders/postgres_loader.py

docs/postgres_loader.md

- Fix regex to capture search_path values with spaces after commas (e.g. $user, public) by matching up to next -c option or EOL - Set session search_path explicitly after connecting so sample queries resolve to the correct schema - Use versionless PostgreSQL docs link (/docs/current/) - Clarify case-sensitivity note for schema names in troubleshooting Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

api/loaders/postgres_loader.py

Replace (.+?)(?=\s+-c|\s*$) with [^\s,]+(?:\s*,\s*[^\s,]+)* to eliminate polynomial backtracking flagged by CodeQL. The new pattern uses unambiguous character classes with no overlapping quantifiers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.

api/loaders/postgres_loader.py

app/src/components/modals/DatabaseModal.tsx

docs/postgres_loader.md

…L encoding - DatabaseModal: Show validation error for invalid schema characters instead of silently stripping them. Throw error on submit if invalid chars present. - docs: URL-encode the example URL to prevent copy/paste connection failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The URL-encoded form (-csearch_path%3Dmy_schema) inside the Liquid capture block triggers spellcheck failures ('csearch', 'Dmy'). Reverted to readable form since Python's urlparse handles both formats fine. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

railway-app bot temporarily deployed to queryweaver / QueryWeaver-pr-475 March 9, 2026 08:32 Destroyed

overcut-ai bot reviewed Mar 9, 2026

View reviewed changes

railway-app bot temporarily deployed to queryweaver / QueryWeaver-pr-475 March 9, 2026 08:43 Destroyed

gkorland requested a review from Copilot March 9, 2026 08:59

Copilot started reviewing on behalf of gkorland March 9, 2026 08:59 View session

railway-app bot temporarily deployed to queryweaver / QueryWeaver-pr-475 March 9, 2026 09:02 Destroyed

chore: remove accidentally committed build artifacts

7cb758c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

railway-app bot temporarily deployed to queryweaver / QueryWeaver-pr-475 March 9, 2026 09:02 Destroyed

Copilot AI reviewed Mar 9, 2026

View reviewed changes

api/loaders/postgres_loader.py Outdated Show resolved Hide resolved

api/loaders/postgres_loader.py Show resolved Hide resolved

docs/postgres_loader.md Outdated Show resolved Hide resolved

docs/postgres_loader.md Outdated Show resolved Hide resolved

railway-app bot temporarily deployed to queryweaver / QueryWeaver-pr-475 March 9, 2026 09:06 Destroyed

chore: gitignore build artifacts

3075e95

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

railway-app bot temporarily deployed to queryweaver / QueryWeaver-pr-475 March 9, 2026 09:06 Destroyed

github-advanced-security bot found potential problems Mar 9, 2026

View reviewed changes

api/loaders/postgres_loader.py Fixed Show fixed Hide fixed

railway-app bot temporarily deployed to queryweaver / QueryWeaver-pr-475 March 9, 2026 09:27 Destroyed

gkorland requested a review from Copilot March 9, 2026 09:44

Copilot started reviewing on behalf of gkorland March 9, 2026 09:45 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

api/loaders/postgres_loader.py Show resolved Hide resolved

app/src/components/modals/DatabaseModal.tsx Show resolved Hide resolved

docs/postgres_loader.md Show resolved Hide resolved

docs/postgres_loader.md Show resolved Hide resolved

railway-app bot temporarily deployed to queryweaver / QueryWeaver-pr-475 March 9, 2026 09:52 Destroyed

railway-app bot deployed to queryweaver / QueryWeaver-pr-475 March 9, 2026 09:57 View deployment

Conversation

gkorland commented Mar 9, 2026

Summary

What changed

Fixes over original PR #373

Backward compatibility

Uh oh!

overcut-ai bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Completed Working on "Code Review"

Uh oh!

railway-app bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

License Issues

uv.lock

OpenSSF Scorecard

Scanned Files

Uh oh!

coderabbitai bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

overcut-ai bot left a comment

Choose a reason for hiding this comment

Summary of findings

Key themes observed

Actionable next steps

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

overcut-ai bot commented Mar 9, 2026 •

edited

Loading

railway-app bot commented Mar 9, 2026 •

edited

Loading

github-actions bot commented Mar 9, 2026 •

edited

Loading

coderabbitai bot commented Mar 9, 2026 •

edited

Loading