Trim stray trailing whitespace in pl_PL provider data - #1069
Open
AleksanderSzutBackupAccount wants to merge 1 commit into
Open
Trim stray trailing whitespace in pl_PL provider data#1069AleksanderSzutBackupAccount wants to merge 1 commit into
AleksanderSzutBackupAccount wants to merge 1 commit into
Conversation
Three entries in the pl_PL provider carried an accidental trailing space: the street name "Staffa " and the bank names "BNP Paribas S.A. Oddział w Polsce " and "John Deere Bank S.A. Spółka Akcyjna Oddział w Polsce ". The padded street name in particular breaks round-trip assertions in consumer test suites: a framework that trims request input (for example Laravel's TrimStrings middleware) stores "Staffa" while the test still compares against the raw "Staffa " it fed in. No entries are added or removed, so seeded generators keep producing the same sequence. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
pwsdotru
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Three entries in the
pl_PLprovider carry an accidental trailing space:Provider/pl_PL/Address.php:172'Staffa 'Provider/pl_PL/Payment.php:41'BNP Paribas S.A. Oddział w Polsce 'Provider/pl_PL/Payment.php:67'John Deere Bank S.A. Spółka Akcyjna Oddział w Polsce 'They are the only padded values in the locale — every one of the other 534 street names and 100+ bank names is clean — so this is a typo rather than intentional data.
The street name is the one that actually bites. When a seeded value is sent through an application that trims request input (Laravel, for instance, ships
TrimStringsin its default global middleware stack), the framework persistsStaffawhile the test still asserts against the rawStaffait generated, and the test fails for a reason that has nothing to do with the code under test. It took a while to trace that back to the fixture data.Author's checklist
Summary of changes
pl_PLstreet name or bank name is padded with whitespace (AddressTest::testStreetNamesAreNotPaddedWithWhitespace, newPaymentTest::testBankNamesAreNotPaddedWithWhitespace). Both fail on1.24before the fix and pass after it.CHANGELOG.mdentry under Unreleased.On "avoid changing existing sets of data": no entry is added, removed or reordered, so seeded generators keep producing the same element at the same index — only the stray space at the end of three strings goes away.
Verified locally on PHP 8.4:
vendor/bin/phpunit→ 2464 tests, 12988 assertions, 0 failures (100 skips are the pre-existing PHP-version-gated ones), andphp-cs-fixer --dry-runreports 0 of 691 files to fix.The same
'Staffa 'typo exists on the2.0branch (src/Provider/pl_PL/Address.php:172); happy to open the equivalent PR there if you'd like it in the same pass.