fix optifine#2
Merged
thecatcore merged 1 commit intoFabricCompatibilityLayers:1.13.2-fabricated-v1from Feb 19, 2025
tildejustin:1.13.2-fabricated-v1
Merged
fix optifine#2thecatcore merged 1 commit intoFabricCompatibilityLayers:1.13.2-fabricated-v1from tildejustin:1.13.2-fabricated-v1
thecatcore merged 1 commit intoFabricCompatibilityLayers:1.13.2-fabricated-v1from
tildejustin:1.13.2-fabricated-v1
Conversation
…verwrite being too low after optifine's patches
Member
|
Thanks for this fix! |
thecatcore
merged commit fda7cb7
into
FabricCompatibilityLayers:1.13.2-fabricated-v1
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1 -- kinda
this will allow Rift on its own to load OptiFine. it will still crash if Optifabric is present, but that's REI's fault (it loads Util and triggers a Fabric ASM mixin apply before Fabricated-Rift runs REI's own init listener that adds its mixins). ReflectorForge#getOptiFineResourceStream is what OptiFine uses in its own VanillaPack patch so I figure this is fine.