feat(cli): add JSON output to the list subcommand#16
Merged
Conversation
Add --format/-f flag to the list subcommand with choices text (default) and json.
JSON output is [{"app": "...", "model": "..."}, ...], matching the issue spec.
Default text output remains unchanged for backward compatibility.
Co-Authored-By: Kimi K2.7 Code <noreply@kimi.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe CLI ChangesCLI list JSON output
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant CLIArguments
participant build_parser
participant _cmd_list
participant stdout
CLIArguments->>build_parser: provide --format or -f
build_parser->>_cmd_list: pass selected format
_cmd_list->>stdout: emit text lines or JSON array
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds JSON output support to the
django-orm-lens listsubcommand.Flag form
I chose
--format json(and-f json) rather than a separate--jsonflag because that is exactly howscananddescribealready expose structured output. Using the same--formatmechanism keeps the CLI predictable and avoids inventing a parallel flag.Output shape
django-orm-lens list --format jsonprints:[ {"app": "app_name", "model": "ModelName"}, ... ]Backward compatibility
Bare
django-orm-lens liststill emits oneapp.Modelline per model — byte-for-byte unchanged.Tests
cli/tests/test_list_command.pycovering default text output and JSON output shape.Gates
pytest -qfromcli/: 47 passedruff check django_orm_lens tests: only pre-existing lint warnings (none introduced by this change)Closes #8
Prepared with AI assistance (Kimi K2.7 Code), human-reviewed before submission.
Summary by CodeRabbit
New Features
listcommand via--format jsonor-f json.Documentation
Tests