DIR: don't display invalid data with devices #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing `DIR NUL` findfirst will actually return success with an attribute indicating a device exists with that name. MS-DOS shows 'File not found' in this case, but FreeCOM (and also Comcom64) can display invalid data, so let's correct that. Since the required constant FA_DEVICE isn't always present in `dos.h`, let's define it when necessary. [FDOS#181] Before (C: is MFS, D: is FAT16): ~~~ C:\>dir nul Volume in drive C is IR DXXXXS C Directory of C:\ NUL 0 10-30-25 6:55p 1 file(s) 0 bytes 0 dir(s) 49,839 Mega bytes free C:\>d: D:\>dir nul Volume in drive D has no label Volume Serial Number is 4A09-DBB4 Directory of D:\ NUL 0 10-30-25 6:55p 1 file(s) 0 bytes 0 dir(s) 42,698,752 bytes free ~~~ With patch (C: is MFS, D: is FAT16): ~~~ C:\>dir nul Volume in drive C is IR DXXXXS C Directory of C:\ File not found. C:\>d: D:\>dir nul Volume in drive D has no label Volume Serial Number is 4A09-DBB4 Directory of D:\ File not found. ~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
DIR NULfindfirst will actually return success with an attribute indicating a device exists with that name. MS-DOS shows 'File not found' in this case, but FreeCOM (and also Comcom64) can display invalid data, so let's correct that. Since the required constant FA_DEVICE isn't always present indos.h, let's define it when necessary.[#181]
Before (C: is MFS, D: is FAT16):
With patch (C: is MFS, D: is FAT16):