Repository navigation
Update rabbitmq Docker tag to v4 - #112
Open
renovate[bot] wants to merge 3 commits into
Open
renovate[bot] wants to merge 3 commits into
renovate[bot] wants to merge 3 commits into
Conversation
renovate
Bot
force-pushed
the
renovate/rabbitmq-4.x
branch
from
September 24, 2024 14:59
64f4549 to
1bcec56
Compare
Brutus5000
force-pushed
the
develop
branch
5 times, most recently
from
October 13, 2024 18:33
abe3548 to
ab2d09d
Compare
Brutus5000
force-pushed
the
develop
branch
23 times, most recently
from
October 23, 2024 06:53
f6ac01f to
8c50cff
Compare
Brutus5000
force-pushed
the
develop
branch
21 times, most recently
from
November 2, 2024 23:01
ca6d2c7 to
d366c25
Compare
renovate
Bot
force-pushed
the
renovate/rabbitmq-4.x
branch
from
November 3, 2024 11:33
e71206c to
0136e2f
Compare
renovate
Bot
force-pushed
the
renovate/rabbitmq-4.x
branch
from
November 3, 2024 11:43
0136e2f to
64ab75c
Compare
Brutus5000
force-pushed
the
develop
branch
2 times, most recently
from
November 3, 2024 23:03
2d31600 to
fa58b0b
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the
 |
Every co-op mission has a thumbnail URL and none of them had a file
behind it. CoopMapEnricher mints
maps/previews/{small,large}/<folder>.vNNNN.png out of the zip name and
never checks that it exists; the vault upload path writes previews in
MapService.generatePreview, but co-op missions do not go through it,
they come through this deployer, which never wrote one. Measured
against the live CDN on 2026-08-21: of 42 mission folders, zero had the
file the API points at.
What clients show instead is whatever art happens to sit in the map
folder, which is why some missions have a preview, some have none, and
two have the wrong one. Operation Red Revenge arrived complete in #417
with preview art from an earlier draft of its own terrain. Tha Atha
Aez is worse: #417 replaced its .scmap and left the .png and .dds from
2017 untouched, so its preview is seven years older than the map and
shows a different one, letterboxed because that map was not square.
Previews are now produced here, from three sources in a fixed order:
- the preview embedded in the mission's own .scmap (31 missions),
which is the only source that cannot disagree with the terrain
- the .dds beside the map (12), for the missions whose map is not in
this repository at all but part of the game install. Same 256 by
256 BGRA layout, so the same decoder reads it, and it beats the
100 by 100 .png next to it
- the stock map the mission's own _scenario.lua names (1), for Novax
Station Assault, which has no image of its own anywhere. Its map is
X1MP_012, whose vault preview already sits in this directory
The order is the point. Both missions with wrong art have a *matching
pair* of wrong sidecars, so a sidecar that could win over a map file
would preserve exactly those two bugs.
Not com.faforever.commons' PreviewGenerator: run over all 44 missions,
all 44 fail. It reads marker art from resources the published data
artifact does not contain (ImageIO gets a null stream), and it takes
marker positions from evaluating _save.lua, which a third of the
campaign missions refuse. Both are the marker overlay, not the picture,
so this takes the picture. The .scmap layout it needs is the one
ScmapPathFixer already walks and CI already verifies byte for byte.
Sizes follow the current vault convention, 128 and 512. The CDN still
carries older 100 and 256 files from before it, which is why the stock
map fall back re-renders rather than copies.
An unchanged mission is never rezipped, so ensureMapPreviews fills in
what is missing on any run: the existing missions get their previews
without waiting to be edited.
verifyCoopPreviews renders every mission in a MAPS_REPO checkout and
reports the source, size and colour count per mission. It fails if a
mission with a real map file produces nothing, if an image is a single
flat colour, or if no mission rendered from its own map file at all.
* add faf-player-service * use versioned player-service * add geoip database update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.13.7-management-alpine→4.4.0-management-alpineConfiguration
📅 Schedule: (UTC)
* 0-3 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.