test: prove sibling flow creation through REST - #3416
Open
chubes4 wants to merge 1 commit into
Open
Conversation
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flow_creation_failed, distinct IDs, and exactly two cards after reloadDetermination
The original production failure was repaired by the shared SQLite savepoint portability fix in #3346 (
a2844a5f). Flow creation already delegates throughPOST /datamachine/v1/flowstodatamachine/create-flow, and no production compensation is needed.The new managed WordPress test executes that real REST path on current main: two POSTs return HTTP 200, produce distinct flow IDs without
flow_creation_failed, and a subsequent REST GET returns both siblings. Production PHP LOC change: 0. Test/fixture impact: +37/-3.Verification
FlowsEndpointTest: 10 passed, 0 failed, 0 skippedFlowCreationAtomicityTest|TransactionScopeTest: 18 passed, 0 failed, 0 skippedThe bounded seven-case runtime-backed browser suite was attempted but blocked before WordPress boot because WP Codebox resolved the nested fixture's
../..runtime requirement against the worktree root, yielding nonexistent/mnt/extrachill-workspace/data-machine.php. Tracked upstream as Automattic/wp-codebox#2385. No runtime product claim is based on that blocked run; the executable managed REST proof is the closure evidence.Fixes #3254.
AI Assistance
OpenAI GPT-5.6 Sol via OpenCode traced the current path, added the focused regression coverage, ran verification, and documented the WP Codebox infrastructure blocker. Chris Huber remains responsible for every line.