Open
Conversation
droguljic
requested changes
Mar 16, 2026
src/components/grafana/grafana.ts
Outdated
| export namespace Grafana { | ||
| export type PrometheusConfig = { | ||
| prometheusEndpoint: pulumi.Input<string>; | ||
| region: pulumi.Input<string>; |
Contributor
There was a problem hiding this comment.
Should region be optional and fallback to the current AWS region used by the stack?
mandryllo
requested changes
Mar 16, 2026
mandryllo
approved these changes
Mar 17, 2026
Comment on lines
+11
to
+13
| prometheusEndpoint: pulumi.Input<string>; | ||
| region?: string; | ||
| prometheusPluginVersion?: string; |
Collaborator
There was a problem hiding this comment.
Don't see the value in prefixing with prometheus here 
mandryllo
requested changes
Mar 17, 2026
| this.prometheusDataSource = new grafana.oss.DataSource( | ||
| `${name}-prometheus-datasource`, | ||
| { | ||
| type: 'grafana-amazonprometheus-datasource', |
Collaborator
There was a problem hiding this comment.
One last thing, I would add a name here so debugging on grafana cloud would be easier (without it it will set the name to something like aws-prometheus-7ee0398)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the Grafana builder and component. It's the first in a series of upcoming PRs.
Dashboard configuration will be covered in the next one.
To instantiate the Grafana component, the following config or env variables need to be set:
GRAFANA_URL,GRAFANA_AUTH,GRAFANA_CLOUD_ACCESS_POLICY_TOKEN,GRAFANA_AWS_ACCOUNT_ID.