Skip to content

feat: add trusted search to user lookup methods - #550

Open
IldarDM wants to merge 1 commit into
ExpressApp:masterfrom
IldarDM:feat/trusted-search-user-lookups
Open

feat: add trusted search to user lookup methods#550
IldarDM wants to merge 1 commit into
ExpressApp:masterfrom
IldarDM:feat/trusted-search-user-lookups

Conversation

@IldarDM

@IldarDM IldarDM commented Aug 11, 2026

Copy link
Copy Markdown

Summary

  • Add trusts_search and partial_response options to user search by HUID, AD login, and other ID.
  • Forward enabled options as query parameters to the corresponding BotX API endpoints.
  • Preserve the existing request shape when both options use their default values.
  • Document trusted search in the user lookup example.

The BotX API exposes these options consistently for all user search endpoints:
https://hackmd.ccsteam.ru/s/E9MPeOxjP

Testing

  • Added trusted-search request tests for HUID, AD login, and other ID.
  • Full test suite: 468 passed.
  • Test coverage: 100%.
  • mypy and ruff passed.

PR checklist

  • I've written good commit message for all commits
  • I've split changes into separate commits where it's appropriate
  • I've added the description of function to documentation
  • I've updated project version in pyproject.toml
  • I'll make a release when PR is merged
  • I'll bump pybotx in bot-template

The release and bot-template updates require maintainer access and are intentionally left for the project maintainers.

Expose trusts_search and partial_response for HUID, AD login, and other ID lookups while preserving the existing request shape by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant