Repository navigation
refactor: separate editor UI and runtime rendering - #438
Merged
Merged
Conversation
Extract a shared tab lifecycle and use tab descriptors to drive view menus and docking. Prefer Common::Path in the new editor interfaces. Keep Editor.Test focused on basic logic and document English-only, pragmatic coding guidelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editor UI, scene editing, and presentation previously shared application and window state. This refactor gives business windows, dockable tabs, and scene viewports explicit responsibilities and lifetimes, with GLFW and ImGui confined to the editor and launcher.
Validation: Debug/Ninja full build passed, including compilation of existing tests and rendering samples; git diff checks passed. Local GUI and runtime tests were not run. The PR Build workflow covers Windows, macOS, and Linux.