[HOLD Onyx#832] Pin react-native-onyx: classify WebKit 'without an in-progress transaction' IDB errors as transient - #99900
Draft
sosek108 wants to merge 1 commit into
Conversation
42 tasks
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Pins
react-native-onyxto the HEAD of Expensify/react-native-onyx#832 so the full E/App test suite runs against it, per the Onyx PR process. After the Onyx PR is merged and published to npm, this PR will be swapped to the pinned version and become the bump PR.The Onyx change classifies WebKit's
UnknownError: Attempt to ... without an in-progress transactionIndexedDB error family asTRANSIENT, so the storage connection layer drops the stale cached connection and retries once with a fresh one instead of propagating. Today this family is classifiedUNKNOWN; when WebKit tears transactions down under a live connection (page reload, foregrounding after process suspension), the boot-timegetAllfails and Onyx starts with default key states only ("Failed to load data from storage during init"), discarding the intact local cache for that session. Only WebKit browsers are affected (iOS Safari, iOS Chrome/Edge/Google shells, macOS Safari).Context: https://expensify.sentry.io/issues/APP-KG and the storage-error cluster in #87844.
Fixed Issues
$ #87844
PROPOSAL:
Tests
Web (any browser, simulating the WebKit failure):
[Onyx] IDB transient error — dropping cached connection and retrying onceand does NOT show[Onyx] IDB error not recoverable at the connection layer, propagating.Regression pass:
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests (the console-injection test requires DevTools; the regression pass applies to staging).
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari