[No QA] [Hold for feature] [No QA] Update help docs for Release 1: Vendor Matching for QuickBooks Online (QBO)#96350
[No QA] [Hold for feature] [No QA] Update help docs for Release 1: Vendor Matching for QuickBooks Online (QBO)#96350MelvinBot wants to merge 7 commits into
Conversation
Adds a standalone Vendor-Matching.md article documenting the imported vendor list, Vendor expense field, auto-matching, default vendor fallback, and export behavior for QBO Credit/Debit card company card expenses (Release 1). Adds minimal cross-links from Configure-Quickbooks-Online.md to avoid duplicating vendor matching logic. Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
stephanieelliott
added
the
HelpDot
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - **Export company card expenses as**: | ||
| - Credit card (default) | ||
| - Debit card | ||
| - Optionally set a **Default vendor** as a fallback for expenses that don't have a vendor set. Learn how vendors are imported, matched, and exported in [QuickBooks Online Vendor Matching](/articles/new-expensify/connections/quickbooks-online/Vendor-Matching). |
There was a problem hiding this comment.
Broken cross-link: Same issue as above — /Vendor-Matching does not exist. Update to /articles/new-expensify/connections/quickbooks-online/Manage-Vendor-Matching-for-QuickBooks-Online so the link resolves to the article added in this PR.
| 3. Under **Export company card expenses as**, select **Credit card** or **Debit card**. | ||
| 4. Select a **Default vendor**. | ||
|
|
||
| The default vendor is used only when an expense doesn't already have a vendor assigned. If no default vendor is configured, expenses export to **Credit Card Misc**. |
There was a problem hiding this comment.
Navigation phrasing: The rest of this doc and the sibling article use "the navigation tabs (on the left on web, on the bottom on mobile)". Here it reads "Click the navigation tabs (on the left on web, on the bottom on mobile), then go to..." — that's fine, but use the exact UI value casing: [workspace name] should be [Workspace Name] to match the placeholder convention used in Configure-Quickbooks-Online.md.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 080e47c187
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
HelpDot Documentation ReviewOverall AssessmentThis PR adds a well-structured standalone article documenting QuickBooks Online vendor matching for non-reimbursable company card expenses, plus two brief cross-links from the existing Configure-Quickbooks-Online.md. The new article is scoped to a single workflow, uses complete YAML frontmatter (including internalScope), and follows the task-based heading model closely. The main concern is a filename/link mismatch that would produce broken cross-links, plus a few small consistency and terminology issues. Scores Summary
Key Findings
Recommendations
Recommendation: Needs work (minor). Content quality is high, but the broken cross-links are a blocking issue that must be resolved before merge. Files Reviewed
Note: This is a top-level summary review based only on the proposed diff. |
Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
|
Fixed the failing Cause: A typo — Fix: Corrected the spelling and pushed to the branch. This was the only failing check (the remaining |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Clarified availability and requirements for QuickBooks Online vendor matching feature for Workspace Admins.
stephanieelliott
changed the title
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
|
A preview of your ExpensifyHelp changes have been deployed to https://f8bf210e.helpdot.pages.dev ⚡️ Updated articles: |
5 participants
Design GH for image: https://github.com/Expensify/Expensify/issues/660973 (
Details
Documents the Release 1 (QuickBooks Online) vendor matching feature for non-reimbursable company card expenses. Per the request on the tracking issue, vendor matching is documented as a standalone help article rather than being folded into the general QBO configuration doc.
What changed
new-expensify/connections/quickbooks-online/Vendor-Matching.md(QuickBooks Online Vendor Matching) covering:Configure-Quickbooks-Online.mdwith two brief cross-links (Import → Vendors, Export → Credit/Debit card → Default vendor) so the config doc stays focused on connection setup and doesn't duplicate vendor matching logic.Scoped in Expensify/Expensify#634620.
Related Issues
Resource Updates tracking issue: Expensify/Expensify#634620
Tests / QA
Help site content only (no code changes). Reviewer should confirm the article accurately describes the Release 1 QBO vendor matching behavior and that feature/UI labels match the shipped product before merge.