Keep Agents selection buttons on the header row in landscape mode#96338
Keep Agents selection buttons on the header row in landscape mode#96338MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com>
|
There's no code failure to fix here — the only failing check is Every actual code check is green:
I also sanity-checked the diff: the new import The Next step: complete the PR Author Checklist and that last check will clear. |
|
🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
All checks are green now — nothing to fix. 🎉 The only check that had been failing was The only item still running is |
Explanation of Change
In landscape mode on narrow screens, the Agents page was rendering the selection-mode header buttons (
1 selected/Select multiple) on a separate row below the header instead of on the header row itself, unlike the Expense Rules page.The placement was gated on the raw
shouldUseNarrowLayoutflag, which istrueon narrow screens in both portrait and landscape. This change switches the two button-placement guards to the existinguseShouldDisplayButtonsInSeparateLine()hook (which returnsshouldUseNarrowLayout && !isInLandscapeMode), matching how the Expense Rules page already handles this. The rest of theshouldUseNarrowLayoutusage (selection-mode header title/icon/back button) is intentionally left unchanged — only the button placement needed the landscape-aware check.Fixed Issues
$ #96297
PROPOSAL: #96297 (comment)
Tests
→ "1 selected" button is shown on the same header as "Select multiple".
Offline tests
N/A
QA Steps
Same as trsts
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
iOS: mWeb Safari