Rename magic code references to validateCode#96328
Conversation
|
@codex review please |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d28d0e3c19
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| MISSING_PERSONAL_DETAILS_CONFIRM_VALIDATE_CODE: { | ||
| path: 'missing-personal-details/:cardID/confirm-validate-code', |
There was a problem hiding this comment.
Preserve legacy magic-code route aliases
Changing this URL slug, along with the other confirm-magic-code and magic-code routes in this commit, makes previously persisted or open URLs unrecognizable after an update. saveCurrentPathBeforeBackground() stores these confirm-screen paths in LAST_VISITED_PATH, and NavigationRoot restores that path on startup; a user who backgrounds the app on one of these screens before upgrading will therefore restore an old path that is no longer present in the linking config instead of returning to the validation flow. Keep the existing slugs or normalize the legacy paths to their new equivalents.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this one is valid, but these aren't really regularly shared URLs so I'm kind of in favor of updating them anyway. Also a user is unlikely to be on these screens and then update their phone and come back to the same screen
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari