[NoQA] fix: Metro Hot-Module-Replacement (HMR)/Hot reload not working on mobile#96325
Conversation
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mountiny do we need to create an E/App issue for this? |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
|
@MelvinBot create an issue for this based on the pr description and linked it to the to pr in the fixed issues section |
|
🤖 Done! Created an issue from this PR's description and linked it in the Fixed Issues section. Issue: #96373 — Metro Hot-Module-Replacement (HMR)/Hot reload not working on mobile The |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
@mountiny @war-in
Explanation of Change
Fixes Metro Hot-Module-Replacement (HMR)/Hot reload not working on mobile. The issue was that a in our custom
moduleInitPolyfilltheinverseDependenciesparameter from Metro implementation was not passed along.Fixed Issues
$ #96373
$ https://expensify.slack.com/archives/C01GTK53T8Q/p1784127526076839
PROPOSAL:
Tests
npm start{ backgroundColor: 'red'}or similar to some container inSidebarLinks.tsx.Offline tests
None needed.
QA Steps
None needed.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-16.at.17.44.52.mov
iOS: Native
Screen.Recording.2026-07-16.at.17.39.20.mov