refactor: migrate WorkspacesListPage loading gate to queue-derived truth by BartekObudzinski · Pull Request #96300 · Expensify/App

BartekObudzinski · 2026-07-16T12:56:07Z

Explanation of Change

A loading indicator driven by a stored boolean can get stuck on screen if the write that clears the flag is ever lost. This moves the Workspaces list page off the stored IS_LOADING_APP flag and onto useIsAppLoadPending, which derives the loading state from the in flight request queue instead. A request always leaves the queue once it resolves, so this state cannot get stuck the way a stored flag can. The hook matches OpenApp only, the same scope as the old flag, so background reconnects do not change this loader. Behavior is unchanged today: both the old flag and the new hook feed the same check.

Fixed Issues

$ #96302
PROPOSAL:

Tests

Online, open the Workspaces list. Verify the loading indicator shows while workspaces load, then is replaced by the list (or the empty state) once loading finishes, exactly as on main.
Go offline, then open the Workspaces list. Verify the cached list shows and no loading indicator stays stuck on screen.
With workspaces already loaded, reload the app on the Workspaces page and verify it does not get stuck showing the loading indicator.

Verify that no errors appear in the JS console

Offline tests

Go offline and open the Workspaces list. Verify the cached list renders and no loading indicator is stuck.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-16.at.15.11.11.mov

…with shadow log

…-workspaces

codecov · 2026-07-16T13:01:47Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useInFlightRequests.ts	`100.00% <100.00%> (ø)`
src/pages/workspace/WorkspacesListPage.tsx	`81.70% <100.00%> (ø)`
... and 12 files with indirect coverage changes

melvin-bot · 2026-07-16T13:18:58Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 857b29ea3b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…he full-page loader

BartekObudzinski · 2026-07-16T13:54:02Z

The failing jobs are not mine, its already on main fyi @DylanDylann It requires margin main

trjExpensify · 2026-07-16T14:31:49Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

…-workspaces

DylanDylann · 2026-07-16T17:00:09Z

+ * the queue truth matches the old flag before any PR deletes the flag. Logs once per disagreement transition
+ * (not every render) so a persistent mismatch is a single line, not a flood.
+ */
+function useIsLoadingAppShadowLog() {


The old flag was cleared through finallyData. For write commands, that doesn't run until the entire sequential queue has flushed. The new queue-derived value flips to false as soon as OpenApp leaves the queue, it doesn't wait for anything queued behind it.

So when other writes are sitting behind OpenApp, the new code clears the workspaces loader a bit earlier than the old flag did.

This is the intended benefit of the migration, not a bug. But it looks like the shadow log can't distinguish this case and will still report it as a false positive

Screen.Recording.2026-07-16.at.23.57.41.mov

Good point, the false positive is real: the queue truth clears when OpenApp leaves the queue while the old flag waits for the full flush, so a plain disagreement log can't tell that benign earlier-clear apart from an actual stranded flag. Rather than ship a noisy diagnostic, I removed the shadow log from this PR. We'll bring it back debounced (only report a disagreement that persists past a threshold, which a real strand does and the transient does not) at the point where it actually matters, the PR that deletes IS_LOADING_APP.

DylanDylann · 2026-07-16T17:00:14Z

+    // Temporary safety net for the migration off IS_LOADING_APP: logs when the stored flag and the queue truth disagree.
+    useIsLoadingAppShadowLog();


I'd prefer to move this into useIsAppLoadPending

Dropped the shadow log from this PR entirely, so this is moot for now. When it comes back at the flag-deletion step we'll decide placement then; I'd lean toward keeping it out of the generic useIsAppLoadPending so the permanent queue hook doesn't carry a temporary IS_LOADING_APP-specific diagnostic, but happy to discuss when we get there.

DylanDylann · 2026-07-16T17:04:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-17.at.00.01.03.mov

OSBotify · 2026-07-17T09:31:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-17T09:32:00Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-17T09:37:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96300.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4ce5464d1a2-cbf1d90-0584d1db826f03c709b8af101fa2c40f367f4440/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4ce5464-cbf1d90-3f92a60ba57a77bba9fb741cc2bf568eca54ea1d/index.html

Web 🕸️
https://96300.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

BartekObudzinski added 2 commits July 16, 2026 14:42

feat: migrate WorkspacesListPage loading gate to useIsAppLoadPending …

addf31f

…with shadow log

Merge remote-tracking branch 'upstream/main' into feat/inflight-pilot…

857b29e

…-workspaces

melvin-bot Bot assigned BartekObudzinski Jul 16, 2026

mountiny mentioned this pull request Jul 16, 2026

refactor: migrate WorkspacesListPage loading gate to queue-derived truth #96302

Open

BartekObudzinski marked this pull request as ready for review July 16, 2026 13:18

BartekObudzinski requested review from a team as code owners July 16, 2026 13:18

melvin-bot Bot requested review from DylanDylann and trjExpensify and removed request for a team July 16, 2026 13:18

melvin-bot Bot removed the request for review from a team July 16, 2026 13:18

chatgpt-codex-connector Bot reviewed Jul 16, 2026

View reviewed changes

Comment thread src/pages/workspace/WorkspacesListPage.tsx

Comment thread src/pages/workspace/WorkspacesListPage.tsx

adhorodyski approved these changes Jul 16, 2026

View reviewed changes

fix: scope useIsAppLoadPending to OpenApp so reconnects do not show t…

0ea79f6

…he full-page loader

trjExpensify removed their request for review July 16, 2026 14:31

Merge remote-tracking branch 'upstream/main' into feat/inflight-pilot…

8769a51

…-workspaces

DylanDylann reviewed Jul 16, 2026

View reviewed changes

refactor: drop the migration shadow log from the pilot, keep it minimal

42af4d5

DylanDylann approved these changes Jul 16, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 16, 2026 18:29

mountiny approved these changes Jul 17, 2026

View reviewed changes

mountiny merged commit 4ce5464 into Expensify:main Jul 17, 2026
38 checks passed

		// Temporary safety net for the migration off IS_LOADING_APP: logs when the stored flag and the queue truth disagree.
		useIsLoadingAppShadowLog();

Uh oh!

Conversation

BartekObudzinski commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 16, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

BartekObudzinski commented Jul 16, 2026

Uh oh!

trjExpensify commented Jul 16, 2026

Uh oh!

DylanDylann Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jul 16, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

BartekObudzinski commented Jul 16, 2026 •

edited

Loading

codecov Bot commented Jul 16, 2026 •

edited by github-actions Bot

Loading