Make system/violation messages text-selectable on desktop web#92142
Draft
MelvinBot wants to merge 1 commit into
Draft
Make system/violation messages text-selectable on desktop web#92142MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Sahil <thesahindia@users.noreply.github.com>
Contributor
Author
|
@thesahindia I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Allow system/violation messages in chat (hold/unhold, approved, rejected, dismissed violation, modified expense, etc.) to be text-selectable and copyable on desktop web.
Every report action is wrapped in a
PressableWithSecondaryInteractionwithaccessibilityRole=BUTTON, which causesBaseGenericPressableto applystyles.userSelectNone(CSSuser-select: none). Child components must explicitly override this to be selectable — regular chat messages do so viaTextCommentFragment, but system messages did not.This PR applies the same pattern already used by
TextCommentFragmentandDotIndicatorMessageto the two system-message renderers:ReportActionItemBasicMessage.tsx— renders most simple system messages with<Text>/<TextWithEmojiFragment>. Now appliesstyles.userSelectTexton desktop web (and keepsstyles.userSelectNoneon touch/narrow layouts).ReportActionItemMessageWithExplain.tsx— renders modified-expense messages viaRenderHTML. The hard-codedisSelectable={false}is changed to the same conditional!canUseTouchScreen() || !shouldUseNarrowLayout.Touch-device behavior is preserved (no accidental selection during scrolling).
Fixed Issues
$ #84639
PROPOSAL: #84639 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — this is a pure UI/style change with no network behavior.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari