[Draft] Display Show history button in Concierge side panel on native#92133
Draft
MelvinBot wants to merge 1 commit into
Draft
[Draft] Display Show history button in Concierge side panel on native#92133MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
- Mount SidePanel on native via RootNavigatorExtraContent so IsInSidePanelContext is provided - Delegate native SidePanelButton to SidePanelButtonBase so the help button opens the side panel - Align native useOpenConciergeAnywhere with web (openSidePanel + isInSidePanel: true) - Disable Modal padding on the native SidePanel modal to avoid double padding Co-authored-by: cretadn22 <cretadn22@users.noreply.github.com>
7 tasks
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This is a draft PR sharing the proposed code diff for issue #89571 so the C+ team can test the changes ahead of approval.
The native Concierge entry-points (
SidePanelButton,useOpenConciergeAnywhere) bypass the side-panel flow and open Concierge as a regular report screen. Because<SidePanel/>is never mounted on native (RootNavigatorExtraContent/index.native.tsxreturnsnull), theIsInSidePanelContext.Providernever executes,useIsInSidePanel()always returnsfalse, andShowPreviousMessagesButtonearly-returns.Changes:
<SidePanel/>on native viaRootNavigatorExtraContent/index.native.tsx(mirroring the web variant). The component self-guards onsidePanelNVP, so it is inert untilopenSidePanel()is called.SidePanelButton/index.native.tsxtoSidePanelButtonBase, so the help button callsopenSidePanel()like web.useOpenConciergeAnywhere/index.native.tsxwith the web variant (openSidePanel()+isInSidePanel: true).shouldUseModalPaddingStyle={false}to the nativeSidePanelModalto remove double padding betweenModalandReportScreen(as noted bypaulnjsin the issue thread).Fixed Issues
$ #89571
PROPOSAL: #89571 (comment)
Tests
Offline tests
Same as Tests, performed offline. Verify the side panel opens, the empty list renders, and no errors appear.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveScreenshots/Videos
Android: Native
iOS: Native
MacOS: Chrome / Safari