[No QA] [Hold for feature] [No QA] Update help docs for Release 3: Custom Agents#92128
[No QA] [Hold for feature] [No QA] Update help docs for Release 3: Custom Agents#92128MelvinBot wants to merge 11 commits into
Conversation
Adds the Custom Agents article and the new Agents hub, and adds short pointers from the Approvals and Workspace Rules articles to the new Custom Agents documentation. Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Updated the title and description for clarity, refined instructions for creating and managing Custom Agents, and improved the overall structure of the document.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Clarified the description of Custom Agents and their role in approval workflows.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@Beamanator @strepanier03 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0890d28d4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
The failing checks aren't related to the PR's code:
No push needed. |
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a new "AI Agents" hub and a comprehensive article on creating and using Custom Agents, along with cross-link additions to two existing workspace articles (Add-Approvals.md and Workspace-Rules.md). The new article is well-organized, covers the workflow thoroughly, and follows most governance conventions. However, there are two broken cross-links and a few heading and navigation phrasing issues that should be resolved before merge. Scores Summary
Key FindingsCritical -- must fix:
Should fix:
Positive aspects:
Recommendations
Files Reviewed
|
|
The failing checks aren't actionable — no code fix is needed:
All other checks are passing. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
A preview of your ExpensifyHelp changes have been deployed to https://883d0dcb.helpdot.pages.dev ⚡️ Updated articles: |
|
This is ready if you want to give it a review @yuwenmemon! Couple notes:
|
@stephanieelliott note: Design request for images here, no need to block article publishing on these!
Summary
Updates the help site for Release 3 of the Custom Agents project — the first customer-facing release, which promotes agents inside workspace Approvals and Rules.
What's new
docs/articles/new-expensify/agents/Custom-Agents.md— explains what Custom Agents are, how to create one (from Settings > Agents or inline from a workflow), how to write agent instructions, how to chat with and Copilot into an agent, how to edit/delete an agent, and how to use an agent as an approver.docs/_data/_routes.ymlunder the New Expensify section, pointing at/new-expensify/hubs/ai-agents/.docs/articles/new-expensify/workspaces/Add-Approvals.md— shortSet a Custom Agent as Approversubsection under Configure Approval Workflows, with a link to the new article.docs/articles/new-expensify/workspaces/Workspace-Rules.md— one line under the overview noting that an agent can be used as an approver when approval logic doesn't fit the standard rules engine.Context
Scoping issue: Expensify/Expensify#642268
This PR follows the Release 3 scope outlined in the resource updates issue: one new landing article and two minor pointer additions. The agent feature is additive — it does not change how existing approvals or rules work — so no broader revisions are needed.
Billing details and personal agent usage are intentionally deferred to Releases 4 and 5.
Test plan
Custom-Agents.mdarticle renders at/new-expensify/hubs/agents/Custom-Agents.i guess i need to add the checklist
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos