refactor: Add post-expense-creation navigation helpers

[TaduJR]

Explanation of Change

Creates two new navigation utilities in src/libs/Navigation/helpers/ as the second step of #84631. These will be called by UI components in subsequent PRs when navigation is moved out of the IOU action layer.

• navigateAfterExpenseCreate - handles post-creation navigation: either dismisses modal and opens the report, or navigates to the Search page (Expenses/Invoices) when created from the FAB.
• dismissModalAndOpenReportInInboxTab - handles modal dismissal across multiple layout contexts (super-wide RHP, wide RHP, search page, default).

Key difference from the existing action-layer functions: hasMultipleTransactions is an explicit parameter instead of reading from an Onyx-connected module variable, and shouldHandleNavigation is removed since UI callers will always navigate when they call these utilities.

No callers are wired up in this PR - that happens in subsequent PRs.

Fixed Issues

$ #84631
PROPOSAL: #84631 (comment)

Tests

1. Open a 1:1 DM chat with another user
2. Tap the + button in the message composer, select Pay someone [name]
3. Enter an amount, tap Next
4. On the confirmation screen, select Pay elsewhere from the payment method dropdown and confirm
5. Verify the modal dismisses and you land back on the 1:1 DM chat
6. Repeat steps 1-3, but on the confirmation screen select Pay with Expensify (requires wallet setup)
7. Verify the same result: modal dismisses, payment visible in the chat
8. Tap the + (FAB) button, and if a Pay [name] quick action appears, tap it
9. Enter an amount on the amount screen, select a payment method from the dropdown, and tap the button
10. Verify the payment is sent directly (no confirmation screen) and the modal dismisses to the chat with the payment visible
11. Repeat steps 1-5 but start from the Search tab (open a 1:1 DM report in the RHP first, then tap + to pay)
12. Verify the modal dismisses correctly and the report is shown

• Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/IOU/SendMoney.ts	0.00% <ø> (ø)
...rc/pages/iou/request/step/IOURequestStepAmount.tsx	65.34% <ø> (ø)
...es/iou/request/step/IOURequestStepConfirmation.tsx	55.49% <0.00%> (-0.19%)	⬇️
...s/Navigation/helpers/navigateAfterExpenseCreate.ts	0.00% <0.00%> (ø)
...ion/helpers/dismissModalAndOpenReportInInboxTab.ts	0.00% <0.00%> (ø)
... and 16 files with indirect coverage changes

[linhvovan29546]

No callers are wired up in this PR - that happens in subsequent PRs.

@TaduJR Can we add at least one caller here to ensure the function works as expected?

[TaduJR]

@linhvovan29546

Sure thing, we could but that is going to be started on step 3 from the proposal currently the step 2 says this

Step 2: Create a navigation utility in the Navigation helpers layer
Extract the navigation logic from dismissModalAndOpenReportInInboxTab and the navigation portion of handleNavigateAfterExpenseCreate into a utility in src/libs/Navigation/helpers/. This is a plain function (not a hook) so it avoids hook rules constraints and can be called from callbacks, loops, or conditional branches within view-layer code. Important constraint: this utility must only be invoked from view-layer entrypoints (components and hooks), never from src/libs/actions/ or action-adjacent files, otherwise we recreate the same violation this issue is fixing.
App

But if you insist we can do that.

BTW I was thinking to create an ESLint rule to not introduce this again WDYT?

Important constraint: this utility must only be invoked from view-layer entrypoints (components and hooks), never from src/libs/actions/ or action-adjacent files, otherwise we recreate the same violation this issue is fixing.

[linhvovan29546]

Sure thing, we could but that is going to be started on step 3 from the proposal currently the step 2 says this

Please add at least one caller to ensure the function works as expected. This is part of the plan and can be adjusted when we open the PR

BTW I was thinking to create an ESLint rule to not introduce this again WDYT?

We can add the ESLint rule, but let’s discuss it after the final PR

[TaduJR]

@linhvovan29546

Added sendMoneyElsewhere and sendMoneyWithWallet as callers both UI callsites (IOURequestStepConfirmation.tsx and IOURequestStepAmount.tsx) now use the new dismissModalAndOpenReportInInboxTab helper directly.

For navigateAfterExpenseCreate, wiring up a caller requires removing shouldHandleNavigation from an action function, which is PR 3's scope. Since navigateAfterExpenseCreate internally delegates to dismissModalAndOpenReportInInboxTab, the lower-level utility is already exercised through the sendMoney wiring.

WDYT about navigateAfterExpenseCreate?

[linhvovan29546]

@TaduJR I think we can remove shouldHandleNavigation, right?

[TaduJR]

@linhvovan29546

Yes, we can remove shouldHandleNavigation from one function (e.g. submitPerDiemExpense) in this PR to prove navigateAfterExpenseCreate works end-to-end.