Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 359ffed10b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| description: translate('initialSettingsPage.helpPage.conciergeChatDescription'), | ||
| icon: icons.ConciergeAvatar, | ||
| iconType: CONST.ICON_TYPE_AVATAR, | ||
| onPress: () => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(conciergeReportID)), |
There was a problem hiding this comment.
Route concierge item through concierge resolver
The new Help menu action navigates directly to ROUTES.REPORT_WITH_ID using conciergeReportID, but that ID is legitimately absent for some sessions (e.g., before report data finishes loading or when the concierge chat has not been created yet). In those cases this builds an invalid r/undefined route instead of opening/creating the concierge chat, which is the behavior provided by the existing navigateToConciergeChat/ROUTES.CONCIERGE flow.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
used navigateToConciergeChat as suggested to be consistent with other places
Explanation of Change
Added a concierge menu item in the help page.
Fixed Issues
$ #85992
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-03-28.at.01.14.47.mov
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-03-28.at.01.18.07.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-25.at.18.30.52.mov