Skip to content

[No QA] Docs updates for E/A#99992 document Paid by column and filter - #100057

Draft
MelvinBot wants to merge 1 commit into
mainfrom
melvin/docs-paid-by-column-99992
Draft

[No QA] Docs updates for E/A#99992 document Paid by column and filter#100057
MelvinBot wants to merge 1 commit into
mainfrom
melvin/docs-paid-by-column-99992

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up to #99992, which fixed the Paid by column so it resolves the payer from live report actions (the column previously stayed blank after paying from Spend until the search was re-run) and moved the Paid by filter down next to Paid status.

Neither the Paid by column nor the paid-by: search operator was documented anywhere on the help site, and the one article that covers Spend columns had stale navigation. This PR closes those gaps.

docs/articles/new-expensify/reports-and-expenses/Using-Reports-in-New-Expensify.md

  • Corrected the column customization steps. The article said to click a Columns icon next to Filters; the live UI has no such icon. You click Display, then select Edit columns. Fixed in both the numbered steps and the closing sentence.
  • Added a Paid by column entry, noting it stays blank until the report is paid and now updates as soon as you pay from Spend — the behavior [cp staging] Update Paid by column from live payment actions #99992 delivers.
  • Removed a duplicated Paid status bullet. The list had the same column twice with two different descriptions; kept one, with the value names bolded consistently.
  • Documented where the Paid by filter sits after [cp staging] Update Paid by column from live payment actions #99992 moved it: below Paid status on the Expense Report type, and below Paid on the Expense type.
  • Added retrieval keywords for the Paid by column and filter.

docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md

  • Documented the paid-by: operator in both the expenses and the reports operator lists. It is a real, shipped operator (CONST.SEARCH.SYNTAX_FILTER_KEYS.PAID_BYpaid-by) backed by a user picker, and it was missing from both lists.

How the UI labels were verified

Every label in this PR was read off the live NewDot web UI rather than inferred from code, per docs/HELPSITE_NAMING_CONVENTIONS.md:

  • Reports toolbar: Filters, Display, Save, Create — there is no Columns icon.
  • Display menu contains exactly Sort by and Edit columns.
  • Edit columns list includes Paid by in sentence case (not "Paid By").
  • Reports filter order: Type, Status, From, To, then Date, Total, Amount debited, Amount reimbursed, Currency, Exported to, Paid status, Paid by, Title, …
  • Expenses filter order: …, Exported to, Paid, Paid by, Withdrawal ID, …

There is no Paid date filter in the Reports view — only a generic Date filter — so the article does not mention one.

Not changed: this article predates the current authoring spec and uses several top-level # headings, which docs/HELP_AUTHORING_GUIDELINES.md Section 4 disallows. Restructuring it is out of scope for a fix follow-up and would bury these corrections in a rewrite.

Fixed Issues

$
PROPOSAL:

Documentation follow-up to #99992. No separate issue to link.

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — help site content only. No app code is changed.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Follow-up to #99992. Documents the Paid by column and the paid-by search operator, corrects the column customization steps to Display > Edit columns, and removes a duplicated Paid status bullet.

Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 1, 2026 15:31
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 1, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#99992 document Paid by column and filter [No QA] Docs updates for E/A#99992 document Paid by column and filter Sep 1, 2026
@OSBotify

OSBotify commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants