[No QA] Docs updates for E/A#99992 document Paid by column and filter - #100057
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#99992 document Paid by column and filter#100057MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Follow-up to #99992. Documents the Paid by column and the paid-by search operator, corrects the column customization steps to Display > Edit columns, and removes a duplicated Paid status bullet. Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://7abc333a.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #99992, which fixed the Paid by column so it resolves the payer from live report actions (the column previously stayed blank after paying from Spend until the search was re-run) and moved the Paid by filter down next to Paid status.
Neither the Paid by column nor the
paid-by:search operator was documented anywhere on the help site, and the one article that covers Spend columns had stale navigation. This PR closes those gaps.docs/articles/new-expensify/reports-and-expenses/Using-Reports-in-New-Expensify.mddocs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.mdpaid-by:operator in both the expenses and the reports operator lists. It is a real, shipped operator (CONST.SEARCH.SYNTAX_FILTER_KEYS.PAID_BY→paid-by) backed by a user picker, and it was missing from both lists.How the UI labels were verified
Every label in this PR was read off the live NewDot web UI rather than inferred from code, per
docs/HELPSITE_NAMING_CONVENTIONS.md:There is no Paid date filter in the Reports view — only a generic Date filter — so the article does not mention one.
Not changed: this article predates the current authoring spec and uses several top-level
#headings, whichdocs/HELP_AUTHORING_GUIDELINES.mdSection 4 disallows. Restructuring it is out of scope for a fix follow-up and would bury these corrections in a rewrite.Fixed Issues
$
PROPOSAL:
Documentation follow-up to #99992. No separate issue to link.
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — help site content only. No app code is changed.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.