Bound the submit-time geolocation lookup with a timeout

[adhorodyski]

Explanation of Change

src/libs/getCurrentPosition/index.ts is the only implementation of the app's getCurrentPosition. It now reads getLastKnownPositionAsync first, then falls back to a live request bounded by CONST.GPS.TIMEOUT (15s). A patch adds the timeout field expo-location lacks, forwarding it to Android's setDurationMillis(). New CONST.GPS.MAX_AGE is 60s, because AddressSearch and MapView share the helper.

Why: ManualGeolocationWait spans peaked at 30,385ms over 7 days, across 20,930 samples, 392 of them above 5s. LocationHelpers.prepareCurrentLocationRequest never calls setDurationMillis(), leaving the Play Services default in force.

Fixed Issues

$

PROPOSAL:

Tests

1. Run npx jest tests/unit/getCurrentPositionTest.ts. Five tests pass: the live request receives timeout: CONST.GPS.TIMEOUT; a platform rejection surfaces as a failure and never as a position; a cached fix newer than CONST.GPS.MAX_AGE is served without a live request; a missing cached fix falls back to a live request; a denied permission short-circuits before the cache or a live request is touched.
2. Run npx jest tests/ui/SubmitDetailsPageTest.tsx tests/ui/components/IOURequestStepConfirmationPageTest.tsx. All 31 tests pass.
3. Run npx jest tests/actions/IOU/MoneyRequestTest.ts. All 75 tests pass.
4. Run npm run typecheck. No errors in src/libs/getCurrentPosition/index.ts, src/CONST/index.ts, jest/setup.ts, or tests/unit/getCurrentPositionTest.ts. To confirm the patched LocationOptions type is actually in effect, replace timeout with a bogus key and check that TS2353 fires on that line.
5. Verify the patch applies from a clean install: delete node_modules/expo-location, run npm install, and confirm setDurationMillis is present in node_modules/expo-location/android/src/main/java/expo/modules/location/LocationHelpers.kt.

• Verify that no errors appear in the JS console

Offline tests

1. Grant location permission, then put the device in airplane mode.
2. Scan a receipt and tap the confirm button on the confirmation step.
3. Verify the confirm button re-enables within 15 seconds rather than staying disabled indefinitely.
4. Verify the expense is created and queued offline, without GPS coordinates attached.
5. Restore the network and verify the queued expense submits normally.

QA Steps

1. On Android, grant location permission, disable system location services, then scan and submit a receipt. Verify the confirm button re-enables within 15 seconds and the expense submits without coordinates.
2. On Android, re-enable location services and submit another scanned receipt. Verify coordinates are attached again and the confirm button responds within a second or two.
3. On iOS, repeat steps 1 and 2. Verify no change from current behaviour, since iOS was already bounded by CLLocationManager.
4. On web and desktop, block location at the OS or browser level, then scan and submit. Verify the confirm button re-enables within 15 seconds.
5. On every platform above, open AddressSearch and tap "use my current location". Verify the returned address is still correct and not visibly stale.
6. On every platform above, open a map view that pans to the current position. Verify it still centres on the correct location.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️