[No QA] Fix egencia docs - #100043
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| # Enabling the Egencia Feed | ||
| A file feed is an automated data transfer from Egencia to Expensify. | ||
| # Enabling the Egencia Integration |
There was a problem hiding this comment.
Heading violation (multiple # headings, not task-based): Only one # heading (the article title) is permitted, plus optional # FAQ — no other # headings are allowed (HELP_AUTHORING_GUIDELINES.md Sections 4 & 9). Demote this to ##. It must also be task-based, starting with an action verb or question word (Section 2). Suggested: ## How to enable the Egencia integration.
There was a problem hiding this comment.
Here's the fix for this heading:
| # Enabling the Egencia Integration | |
| ## How to enable the Egencia integration |
The same rule breaks four other headings in docs/articles/new-expensify/connections/Egencia.md, so demoting only this one still leaves the article non-compliant. The article needs exactly one # (the title) and task-based ## sections below it (Sections 2 and 4):
| Line | Now | Change to |
|---|---|---|
| 7 | # Getting Started |
# How to connect Egencia to Expensify — generic headings are forbidden, and this is the one # the article gets |
| 11 | ## Requirements |
## What you need to use the Egencia integration — noun-only |
| 18 | # How Egencia Works with Expensify |
## How Egencia works with Expensify |
| 25 | # Enabling the Egencia Integration |
## How to enable the Egencia integration |
| 36 | # Connecting a Central Purchasing Account |
## How to connect a central purchasing account |
| 39 | ## Steps to Enable a Central Purchasing Account |
### How to enable a central purchasing account |
| 44 | ## How It Works |
### How central purchasing account receipts work |
The other review bot comment also flags a missing internalScope key in the frontmatter, which Section 3 makes mandatory:
internalScope: Audience is Control Workspace admins and travelers, covers enabling the Egencia feed and central purchasing account, does not cover Egencia booking itself or other travel partners
⚠️ I can't push changes to this PR because I didn't open it and I'm not listed as an assignee. To have me make this fix, add me to the PR assignees and then retry your request.
There was a problem hiding this comment.
Done — pushed as 25e86c5.
Each article now has exactly one # (the title) with task-based ## sections under it, and the mandatory internalScope key is in the frontmatter.
| Was | Now |
|---|---|
# Getting Started |
# Connect Egencia to Expensify |
## Requirements |
## What you need to use the Egencia integration |
# How Egencia Works with Expensify |
## How Egencia works with Expensify |
# Enabling the Egencia Integration |
## How to enable the Egencia integration |
# Connecting a Central Purchasing Account |
## How to connect a central purchasing account |
## Steps to Enable a Central Purchasing Account |
folded into the section above |
## How It Works |
## What happens after you connect a central purchasing account |
Two things worth flagging:
- I applied the same fix to
docs/articles/expensify-classic/connections/Egencia.md. It was byte-identical to the New Expensify article and is also in this PR's diff, so leaving it would have failed the same rule on the next review pass. - I dropped the
###levels I suggested earlier. TEMPLATE.md says to use only#and##, never###, so the two sub-sections became flat##sections instead.
Only headings and frontmatter changed — no prose was reworded.
I could not run cspell locally in this environment (the command wasn't permitted), so the spellcheck check on this push is the first real verification. The only new terms are internalScope, Admins, and routing, and internalScope already appears in TEMPLATE.md, so I don't expect a failure.
The other bot comment about description/keywords still references "travel booking receipts and expenses" and lists Expensify Classic as a keyword on the New Expensify article. I left both alone since you asked for the heading fix — say the word if you want those updated too.
This comment has been minimized.
This comment has been minimized.
HelpDot Documentation ReviewOverall AssessmentThis PR makes a focused set of edits to Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review reflects only the changes proposed in the diff. |
This comment has been minimized.
This comment has been minimized.
Demote the extra # headings to task-based ## sections so each article has exactly one # title, replace the generic 'Getting Started' and noun-only headings, and add the mandatory internalScope frontmatter key. Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://95874f98.helpdot.pages.dev ⚡️ Updated articles: |
3 participants
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/677339
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari