Fix unread marker disappears after revealing Concierge history in side panel - #100038
Fix unread marker disappears after revealing Concierge history in side panel#100038collectioneur wants to merge 3 commits into
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90afad24e9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| oldestUnreadReportActionID: oldestUnreadReportAction?.reportActionID, | ||
| isScrolledOverThreshold: hasScrolledOverThreshold, | ||
| hasOnceLoadedReportActions: !!hasOnceLoadedReportActions, | ||
| newMessageBoundaryTime: isConciergeHiddenHistory ? sessionStartTime : undefined, |
There was a problem hiding this comment.
Pass the side-panel session timestamp
When Concierge is opened only in the side panel, this reads the main-DM ConciergeSessionContext, whose timestamp remains null because useStartConciergeSession starts it only for isConciergeMainDM. Meanwhile, useReportActionsVisibility lines 69–75 filters side-panel history using SidePanelStateContext.sessionStartTime. Consequently, the exact cold side-panel “Show history” flow passes no boundary here, so the newly revealed unread action is treated as a just-arrived action and the marker is suppressed on the reveal render. Select the same side-panel/main-DM timestamp used by the visibility hook.
Useful? React with 👍 / 👎.
Explanation of Change
Fixes the "New" unread marker disappearing when Concierge hidden history is revealed via "Show history".
useUnreadMarkernow only advances the read watermark when the newest visible action actually advances (a bulk history reveal no longer pushes it past unread messages), ignores the synthetic Concierge greeting as a push target, and a newnewMessageBoundaryTimeparam prevents revealed history actions from being treated as read-on-arrival.Fixed Issues
$ #100006
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-02.at.12.09.15.mov