Remove unsafe assertions from badge and theme style defaults

[KJ21-ENG]

Explanation of Change

Remove four unsafe type assertions from StatusBadge and the default ThemeStyles contexts. Pass existing ColorValue values directly to the background style helper, construct the text color as a typed React Native TextStyle, and replace assertion-backed proxies with typed lazy getters. Preserve the rendered badge colors and the cached styles and StyleUtils identities.

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Tests

1. Open a view that renders a status badge with its default text and background colors.
2. Verify the badge text, background, border, spacing, and tooltip behavior match the current production behavior.
3. Open a view that supplies custom ColorValue text and background colors to a status badge.
4. Verify both custom colors render correctly and no errors appear in the JS console.
5. Navigate between screens that consume useThemeStyles and useStyleUtils.
6. Verify theme styles remain stable and styled components render normally.

Offline tests

1. Repeat the status badge and navigation checks while offline.
2. Verify badge colors and theme-derived styles remain unchanged because these paths do not depend on network data.

QA Steps

1. Repeat the steps in the Tests section on staging.
2. Verify default and custom status badge colors render as expected.
3. Verify theme-styled screens render normally while navigating between them.
4. Verify no errors appear in the JS console.

Count change

Current baseline source: verifier-owned authoritative cleanup count for exact diff sha256:7e68a3a1e9d54eb1b5b67f296205e1407279ae6c8f9f1c6d4a07dc4c4de5bd4b.

Before:

• src/components/StatusBadge.tsx: 2
• src/components/ThemeStylesContextProvider/default.ts: 2

After:

• src/components/StatusBadge.tsx: 0
• src/components/ThemeStylesContextProvider/default.ts: 0

Net reduction:

• 4 unsafe type assertion warnings removed.

TSV evidence: the verifier restored config/eslint/eslint.seatbelt.tsv and confirmed it is not part of the changed-path set.

Changed files

• src/components/StatusBadge.tsx
• src/components/ThemeStylesContextProvider/default.ts

PR Author Checklist

Focused verification, exact-head Fork CI, and three independent reviews cover this narrow assertion cleanup. The change preserves the existing Badge colors and the cached ThemeStyles context identities. It adds no UI, CSS, assets, copy, message editing, Storybook behavior, direct deeplink behavior, or new code pattern. Those checklist categories are N/A. Manual QA remains required by the final regression review.

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A. This cleanup changes no visual output.

Changed files (2)

• src/components/StatusBadge.tsx
• src/components/ThemeStylesContextProvider/default.ts