fix(android): match RN 0.85 ViewManager event-constants signature#2
Open
fix(android): match RN 0.85 ViewManager event-constants signature#2
Conversation
…ypeConstants signature RN 0.85 changed ViewManager.getExportedCustomDirectEventTypeConstants() to return Map<String, Any>? instead of MutableMap<String, Any>. Update the PerformanceMarker view manager override to align with the new contract. Bumps version to 4.1.2-exodus.0.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+145
to
+160
| name: 'NPM Pack with dry-run' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Setup node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ env.NODE_VERSION }} | ||
| - name: Install Yarn | ||
| run: npm install --global yarn | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
| - name: Build Typescript | ||
| run: | | ||
| yarn | ||
| yarn build | ||
| npm pack --dry-run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PerformanceMarker.getExportedCustomDirectEventTypeConstants()override with the RN 0.85 contract (Map<String, Any>?instead ofMutableMap<String, Any>), so the Kotlin override compiles againstReactNative.ViewManager0.85.@exodus/react-native-performanceto4.1.2-exodus.0for republish.Context
Part of the ExodusMovement/exodus-mobile RN 0.78 → 0.85 upgrade. Currently lives in the integration repo as a postinstall patch (
patches-prod/fix-rn-085-performance-event-constants.js); rolling into the fork lets us drop the patch.Test plan
4.1.2-exodus.0, integrate into exodus-mobile, drop the prod patch.raxodus/rn-0.85-upgrade).