Open
Conversation
Owner
|
Hey, sorry for the late response. I did take a look at this PR and I found it quite useful. But I would like you to check a few things before this can get merged. At first I want you to ensure that there are no API breaking changes here and everything is still binary compatible with already compiled code from an earlier api version. |
|
yo @Exceptionflug, are there any news about this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packet listening
Unified packet event class
Now
PacketReceiveEventandPacketSendEventextends a commonAbstractPacketEventclass with the new methodAbstractPacketListener#packetEvent(), this is useful if you want to detect a packet that can be generated by the server and proxy.Functional listeners
Instead of making this:
Now you can make this:
Protocolize player
Packet sending
Now ProtocolizePlayer instance can be used to send packets with different protocols, since
CONFIGURATIONprotocol was added this is quite useful.Protocol information
Get current player protocol from
MinecraftDecoderandMinecraftEncoder.