Defer language server startup until first insert#519
Open
owenthewizard wants to merge 1 commit intoExafunction:mainfrom
Open
Defer language server startup until first insert#519owenthewizard wants to merge 1 commit intoExafunction:mainfrom
owenthewizard wants to merge 1 commit intoExafunction:mainfrom
Conversation
The language server was being started on BufEnter at startup, which caused its stdout/stderr output to be misinterpreted by the terminal as keyboard input. This resulted in garbage appearing in Vim's input buffer that needed to be manually cleared. By deferring the server startup to InsertEnter (when the user first enters insert mode), we avoid this issue while still ensuring the server is available when needed for completions. The guard condition checks codeium_server_started to prevent multiple startup attempts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language server was being started on BufEnter at startup, which caused its stdout/stderr output to be misinterpreted by the terminal as keyboard input. This resulted in garbage appearing in Vim's input buffer that needed to be manually cleared.
By deferring the server startup to InsertEnter (when the user first enters insert mode), we avoid this issue while still ensuring the server is available when needed for completions.
The guard condition checks codeium_server_started to prevent multiple startup attempts.