fix(cli): parse arguments before starting the peer and REST facade - #59
Merged
Merged
Conversation
`cc-peer --help` and `-h` now print usage and exit 0, and an unknown flag, a value flag with no value or an invalid port exits 2 with a usage hint. Parsing is a pure function that runs before any peer is created, socket bound or token minted, so none of these paths have side effects.
Mearman
marked this pull request as ready for review
October 5, 2026 11:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npx cc-peer --helpignored the flag and started the REST facade, registering a peer and printing a bearer token, because the CLI only picked out the options it knew and created the peer first. Arguments are now parsed up front by a pure function:--helpand-hprint usage and exit 0, and an unknown flag, a value flag with no value or an invalid port exits 2 with a hint, all before any peer or socket exists.test/cli.integration.test.tsspawns the real entry with an empty home and checks the exit codes, the absence of a token and that nothing was registered, andsrc/bin/main.unit.test.tscovers the parser.Fixes #58