fix(alias): exit when the parent process goes away instead of lingering as an orphan - #50
Merged
Merged
Conversation
…ng as an orphan An alias worker's only link to its parent is the IPC channel the parent forked it over. When the parent died without stopping it, which any crash or kill does, the channel closed and nothing ended the worker: it stayed registered under its correspondent's name, so a session replying to that name could reach the orphan rather than the live alias, and the orphan's next relay raised an unhandled channel-closed error and dropped the reply. The worker now stops its peer, removing its registry entry, and exits when the channel closes, and only relays to the parent while the channel is open.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in a two-machine test of agent-comms with a real Claude Code session: a reply alias worker outlived the process that had forked it (the old coordinator had been killed, so no stop command was ever sent). It stayed registered under its correspondent's name, so when the front was restarted and created a fresh alias with the same name, the session saw two peers with that name and replied to the orphan. The orphan then tried to relay the reply to a parent that no longer existed, hit an unhandled channel-closed error and dropped it.
The worker now stops its peer and exits when the IPC channel closes, which also removes its registry entry, and only relays to the parent while the channel is open. The new integration test forks the real worker, starts it, closes its channel and checks that it exits cleanly and its registry entry is gone. It times out against the old worker.