fix(ci): drop the redundant version rewrite and its stale comment in the mirror job - #46
Merged
Merged
Conversation
…the mirror job The mirror-github-packages job explicitly rewrote package.json's version on the checked-out release tag, reasoning that @semantic-release/git was absent so nothing ever committed the version bump back to main. That plugin was re-enabled a day later and the comment was never updated. Confirmed directly against the last two releases: the chore(release) commit each tag points at already carries the bumped package.json version, matching the tag. Dropping the now-redundant rewrite and correcting the comment to describe what actually happens today.
Mearman
marked this pull request as ready for review
September 18, 2026 19:33
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45
The mirror-github-packages job's comment claimed @semantic-release/git was absent from release.config.ts, so nothing ever committed the version bump back to main, and it explicitly rewrote package.json's version on the checked-out release tag to compensate. That plugin was re-enabled a day later (see 786ac48) and the comment was never updated.
Confirmed directly against the last two releases (v1.4.1, v1.5.0): each tag's chore(release) commit already carries package.json with that exact version, matching the tag. The explicit
npm pkg set version=...rewrite is a no-op today, so it's removed along with the stale reasoning in the comment; the comment now describes what actually happens.Test plan
pnpm lint/pnpm typecheck/pnpm buildactionlint .github/workflows/ci.yml— no issuespnpm test:coverage(unaffected, workflow-only change)